Renovate: merge WP deps config blocks

[simison]

Proposed changes

Merges the two separate "externalized" and "bundled" wp deps configs into one.

While this makes each update more elaborate (especially when studying changelogs) and harder to grok which packages are "externalized" and which "bundled", it's still beneficial to combine these.

Devs testing need to pay special attention to bundled packages, as they may contain larger changes that affect product UIs. Meanwhile, it's hard to keep up with new packages added to bundled deps, and we may end up with situations where we're updating a package in two separate deploys, potentially days or weeks apart, but they depended on specific versions of each other.

Following changes to what is bundled and what isn't can be challenging, and configs can drift from upstream:

• Jetpack bundles some additional dependencies separately from WP's own determination (see wp-build-polyfill package or various Webpack configs bundling wp-theme).
• WP-Build tool and Webpack configs in Gutenberg use different ways to determine what needs bundling (ref)
• We use wp-theme (an externalised dependency) as part of build and linter processes

Related product discussion/links

• Avoids issues described in peKye1-26O-p2

Does this pull request change what data or activity we track or use?

Testing instructions

• N/A

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/renovate-merge-wp branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/renovate-merge-wp

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/renovate-merge-wp

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[CGastrell]

LGTM, I guess there's no actual way to put this to the test? We might be better off just keeping an eye on next renovate run?

[simison]

It could be tested with a separate repo, but honestly, I don't think this is that risky to do testing like that. :-)

The file is also covered by a basic JSON linter.