fix(theme): open primary navigation on mobile when no docs sidebar exists - #13
Open
burakibaoglu0 wants to merge 1 commit into
Open
Conversation
…ists The header's mobile drawer toggle only ever controlled #docs-sidebar, which exists solely on the docs page template. On the homepage, posts, archives, search, and 404 pages there is no sidebar to open, so tapping the visible hamburger button did nothing and left the primary navigation (Docs, Why DocsPress?, Kitchen Sink, GitHub) unreachable on mobile. The toggle now falls back to opening the primary navigation as a slide-in drawer (reusing the docs sidebar's existing mobile treatment) on pages without a docs sidebar, and the shared drawer-scrim close button moved from the docs-sidebar block to the always-present menu toggle so it works on every template. aria-controls is now set dynamically to whichever element the button actually opens.
burakibaoglu0
force-pushed
the
fix/ibaoglu/mobile-primary-nav-drawer
branch
from
July 27, 2026 21:52
601a70c to
bf17c1b
Compare
burakibaoglu0
changed the title
Author
|
cc @f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header's mobile drawer toggle only ever controlled #docs-sidebar, which exists solely on the docs page template. On the homepage, posts, archives, search, and 404 pages there is no sidebar to open, so tapping the visible hamburger button did nothing and left the primary navigation (Docs, Why DocsPress?, Kitchen Sink, GitHub) unreachable on mobile.
The toggle now falls back to opening the primary navigation as a slide-in drawer (reusing the docs sidebar's existing mobile treatment) on pages without a docs sidebar, and the shared drawer-scrim close button moved from the docs-sidebar block to the always-present menu toggle so it works on every template. aria-controls is now set dynamically to whichever element the button actually opens.