Skip to content

Try: Simplified publish, with Publish site in the top bar - #270

Open
getdave wants to merge 5 commits into
trunkfrom
getdave/global-save-prototypes-rebuild
Open

getdave wants to merge 5 commits into
trunkfrom
getdave/global-save-prototypes-rebuild

Conversation

@getdave

@getdave getdave commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

What does this do?

This is the first phase of a "Simplified publish" prototype. Anything visitors could see now waits for one Publish site button in the top bar, while anything nobody can see yet saves straight away and is never counted as a change.

Why bring back a Publish button outside the canvas?

Since #263, saving lives in the canvas, next to the page being edited. This PR puts a second button back outside it, in the top bar, because two different kinds of things get published, on different timescales and for different people.

Site-wide changes (name, logo, colours, header, menus) affect every page at once. People want to try them, preview them together and put them live in one go, and to roll them back if needed. That's Publish site in the dark top bar. It's there on every screen, including ones with no canvas, so held changes are never stranded.

A page or post is one document with its own life: draft, schedule, publish, then later edits. Writers already know that flow from WordPress's post editor. That's the Save draft / Publish / Save in the canvas, next to the document it belongs to.

Merging them into one button would force a bad choice. Either saving a page would also push half-finished site changes live, or you couldn't publish a page without publishing the whole site too. Webflow does the second, and its users find it confusing. Keeping them apart, with only one shown at a time, lets each control mean exactly one thing.

What's in it?

  • A dark top bar on every screen holds the site's logo and name (which open Name & logo), Go to page, and the publish status. That status is Publish site when changes are waiting, "Up to date" when none are, or a quiet "N site changes waiting" note while a page or post is open.
  • Publish site lists the waiting changes, with those shown on every page first. Each change has its own Discard, and Discard changes… behind the arrow beside Publish drops them all.
  • Pages and posts save and publish in the canvas with core's own header buttons and pre-publish panel, which offers "Also publish N site changes", unticked.
  • Exit asks whether to save, exit without saving or keep editing, and only discards the page's own edits. The first time an edit made on a page turns out to change every page, a notice explains that it waits for Publish site.
  • New menus are drafts and save as you go. Any change to a published menu waits, and Publish site publishes the draft menus that its header and footer changes use.
  • The editor warns before you leave while changes are waiting, because they aren't kept between visits yet.

src/top-bar/README.md sets out the rules for what waits and what doesn't.

What's still open?

This PR leaves the editor with two ways to pick a page. One is Go to page in the new top bar, and the other is the page's name in the canvas toolbar, which opens the same page finder. Having both is a known duplication, not a decision. We need to choose which one stays, and record why, before this direction goes further.

How do I test it?

  1. Change the site name in Name & logo. Publish site appears in the top bar.
  2. Open a page and press Edit. The top bar says "1 site change waiting", and the page's own Save and Publish are in the canvas toolbar.
  3. Exit, then open Publish site. Discard a single change and publish the rest.
  4. Add a new menu and put it in the header. The menu saves as a draft, and publishing the header publishes the menu with it.

The site history built on this flow is #271, stacked on top of this PR.


🤖 Generated with Claude Code

getdave and others added 2 commits November 19, 2026 21:15
Phase 1 of the "Simplified publish" prototype, on today's in-memory
edits. Anything visitors could see waits for Publish site; anything
nobody can see yet saves straight away and is never counted.

- A dark top bar on every screen: the site's logo and name (opens Name &
  logo), Go to page, and Publish site, "Up to date", or a quiet
  "N site changes waiting" note while a page or post is open.
- Publish site lists the waiting changes, every page first, with
  Discard changes behind the Publish button's menu.
- Pages and posts save and publish in the canvas with core's header
  pieces and pre-publish panel, which offers "Also publish N site
  changes", unticked.
- Exit asks to save, exit without saving or keep editing, and only
  discards the page's own edits. A notice explains, once, when an edit
  shows on every page.
- Menus: new menus are drafts and save as you go; any change to a
  published menu, its name included, waits. Publish site publishes the
  draft menus its header and footer changes use.
- Edit and Exit/Save change in one view transition, the toolbar's
  buttons moving on their own rather than inside the canvas's picture.
- Warn before leaving the editor with changes waiting, until they are
  kept between visits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Each change in Publish site has its own Discard again, as on trunk's
  review, with focus moving to the next row's Discard.
- Edit and Exit sit a little apart from the View and Zoom buttons before
  them in the canvas toolbar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@getdave
getdave added this pull request to stack #272 November 19, 2026 21:57
@github-actions

Copy link
Copy Markdown

Try this branch in WordPress Playground, with a WooCommerce shop, for an AI agent to drive, or on a blank site with WordPress's default theme. All run the latest build of getdave/global-save-prototypes-rebuild and update with every push, a few minutes after the Plugin zip build finishes.

To start in a workspace other than Default, open it in Writing, Builder or Selling.

@getdave getdave changed the title getdave/global save prototypes rebuild Try: Simplified publish, with Publish site in the top bar Nov 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@scruffian scruffian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we haven't got this totally right, but this is a step in the right direction.

@getdave
getdave marked this pull request as ready for review November 20, 2026 12:05
getdave and others added 2 commits November 20, 2026 12:33
The e2e tests still looked for the canvas toolbar's save controls and
Review changes, which Publish site replaced.

- New helpers check the top bar's publish status and open Publish site.
- Snackbars, the menu rename button and Exit's dialog match what the
  editor now says and does.
- Two page finders share a name now, the top bar's and the canvas
  toolbar's, so tests pick the canvas toolbar's.
- With the top bar, the pointer can rest on the footer after a section is
  added, which hides the section's bar, so it is moved away first.
- Publish site's arrow menu renders inside the dialog. In core's popover
  container, a dialog opened after the menu was first used hid it from
  screen readers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…blish when scheduled

- A draft menu put in a page or post's content is published when the page
  is published, scheduled or saved while live. Publish site only publishes
  the menus of what it publishes, so the page went live with an empty menu
  nothing then published.
- "Also publish N site changes" now also goes when the page is scheduled,
  not only published, and isn't offered for Submit for Review, which
  publishes nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rCnBtFg3artGYxgKtvdpE
scruffian pushed a commit that referenced this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants