Repository navigation
Conversation
Phase 1 of the "Simplified publish" prototype, on today's in-memory edits. Anything visitors could see waits for Publish site; anything nobody can see yet saves straight away and is never counted. - A dark top bar on every screen: the site's logo and name (opens Name & logo), Go to page, and Publish site, "Up to date", or a quiet "N site changes waiting" note while a page or post is open. - Publish site lists the waiting changes, every page first, with Discard changes behind the Publish button's menu. - Pages and posts save and publish in the canvas with core's header pieces and pre-publish panel, which offers "Also publish N site changes", unticked. - Exit asks to save, exit without saving or keep editing, and only discards the page's own edits. A notice explains, once, when an edit shows on every page. - Menus: new menus are drafts and save as you go; any change to a published menu, its name included, waits. Publish site publishes the draft menus its header and footer changes use. - Edit and Exit/Save change in one view transition, the toolbar's buttons moving on their own rather than inside the canvas's picture. - Warn before leaving the editor with changes waiting, until they are kept between visits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Each change in Publish site has its own Discard again, as on trunk's review, with focus moving to the next row's Discard. - Edit and Exit sit a little apart from the View and Zoom buttons before them in the canvas toolbar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Try this branch in WordPress Playground, with a WooCommerce shop, for an AI agent to drive, or on a blank site with WordPress's default theme. All run the latest build of To start in a workspace other than Default, open it in Writing, Builder or Selling. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scruffian
reviewed
Nov 20, 2026
scruffian
left a comment
Member
There was a problem hiding this comment.
I still think we haven't got this totally right, but this is a step in the right direction.
getdave
marked this pull request as ready for review
November 20, 2026 12:05
The e2e tests still looked for the canvas toolbar's save controls and Review changes, which Publish site replaced. - New helpers check the top bar's publish status and open Publish site. - Snackbars, the menu rename button and Exit's dialog match what the editor now says and does. - Two page finders share a name now, the top bar's and the canvas toolbar's, so tests pick the canvas toolbar's. - With the top bar, the pointer can rest on the footer after a section is added, which hides the section's bar, so it is moved away first. - Publish site's arrow menu renders inside the dialog. In core's popover container, a dialog opened after the menu was first used hid it from screen readers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…blish when scheduled - A draft menu put in a page or post's content is published when the page is published, scheduled or saved while live. Publish site only publishes the menus of what it publishes, so the page went live with an empty menu nothing then published. - "Also publish N site changes" now also goes when the page is scheduled, not only published, and isn't offered for Submit for Review, which publishes nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rCnBtFg3artGYxgKtvdpE
scruffian
pushed a commit
that referenced
this pull request
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This is the first phase of a "Simplified publish" prototype. Anything visitors could see now waits for one Publish site button in the top bar, while anything nobody can see yet saves straight away and is never counted as a change.
Why bring back a Publish button outside the canvas?
Since #263, saving lives in the canvas, next to the page being edited. This PR puts a second button back outside it, in the top bar, because two different kinds of things get published, on different timescales and for different people.
Site-wide changes (name, logo, colours, header, menus) affect every page at once. People want to try them, preview them together and put them live in one go, and to roll them back if needed. That's Publish site in the dark top bar. It's there on every screen, including ones with no canvas, so held changes are never stranded.
A page or post is one document with its own life: draft, schedule, publish, then later edits. Writers already know that flow from WordPress's post editor. That's the Save draft / Publish / Save in the canvas, next to the document it belongs to.
Merging them into one button would force a bad choice. Either saving a page would also push half-finished site changes live, or you couldn't publish a page without publishing the whole site too. Webflow does the second, and its users find it confusing. Keeping them apart, with only one shown at a time, lets each control mean exactly one thing.
What's in it?
src/top-bar/README.mdsets out the rules for what waits and what doesn't.What's still open?
This PR leaves the editor with two ways to pick a page. One is Go to page in the new top bar, and the other is the page's name in the canvas toolbar, which opens the same page finder. Having both is a known duplication, not a decision. We need to choose which one stays, and record why, before this direction goes further.
How do I test it?
The site history built on this flow is #271, stacked on top of this PR.
🤖 Generated with Claude Code