Skip to content

Preserve generic runtime fallback metadata #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Jun 21, 2026
+31 −1
Merged

Preserve generic runtime fallback metadata #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions php-transformer/src/HtmlToBlocks/HtmlTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,7 @@ private function captureInlineSvgFallback(DOMElement $element, array &$fallbacks
private function captureScriptFallback(DOMElement $element, array &$fallbacks): void
{
$boundedHtml = $this->boundedFallbackHtml($this->safeFallbackHtml($element));
$boundedBody = $this->boundedFallbackText(trim($element->textContent ?? ''));
$fallbacks[] = array_merge(array(
'type' => 'html',
'reason' => 'script_requires_runtime',
Expand All @@ -1218,6 +1219,9 @@ private function captureScriptFallback(DOMElement $element, array &$fallbacks):
'html' => $boundedHtml['html'],
'html_bytes' => $boundedHtml['bytes'],
'html_truncated' => $boundedHtml['truncated'],
'body' => $boundedBody['text'],
'body_bytes' => $boundedBody['bytes'],
'body_truncated' => $boundedBody['truncated'],
), $this->fallbackProvenance);
}

Expand Down Expand Up @@ -1258,6 +1262,27 @@ private function boundedFallbackHtml(string $html): array
);
}

/**
* @return array{text: string, bytes: int, truncated: bool}
*/
private function boundedFallbackText(string $text): array
{
$bytes = strlen($text);
if ( $bytes > 2000 ) {
return array(
'text' => substr($text, 0, 2000) . '...',
'bytes' => $bytes,
'truncated' => true,
);
}

return array(
'text' => $text,
'bytes' => $bytes,
'truncated' => false,
);
}

/**
* @return array<string, string>
*/
Expand Down
7 changes: 6 additions & 1 deletion php-transformer/tests/fixtures/parity/html-h2bc-gap-primitives.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"operation": "html_transformer.transform",
"input": {
"content": "<main><div class=\"decorative-placeholder\" style=\"min-height:48px\" aria-hidden=\"true\"></div><div class=\"media-shell\"><img src=\"logo.svg\" alt=\"Logo\" width=\"120\" height=\"80\"></div><dl><dt>Term</dt><dd>Definition</dd></dl><ul class=\"checks\"><li>Parent<ul><li><span class=\"accent\">Child</span></li></ul></li></ul><section class=\"local-widget\"><h2>Signup</h2><form action=\"/signup\"><label>Email <input name=\"email\" placeholder=\"you@example.com\"></label></form><script type=\"module\" src=\"/widget.js\">hydrate()</script></section><figure class=\"code-window\"><figcaption>theme.json</figcaption><pre><code class=\"language-json\">{&quot;version&quot;:2}</code></pre></figure><div class=\"code-frame\" data-filename=\"functions.php\"><pre><code class=\"language-php\">&lt;?php add_action();</code></pre></div></main>"
"content": "<main><div class=\"decorative-placeholder\" style=\"min-height:48px\" aria-hidden=\"true\"></div><div class=\"media-shell\"><img src=\"logo.svg\" alt=\"Logo\" width=\"120\" height=\"80\"></div><dl><dt>Term</dt><dd>Definition</dd></dl><ul class=\"checks\"><li>Parent<ul><li><span class=\"accent\">Child</span></li></ul></li></ul><section class=\"local-widget\"><h2>Signup</h2><form action=\"/signup\"><label>Email <input name=\"email\" placeholder=\"you@example.com\"></label><label><input type=\"checkbox\" name=\"agree\" value=\"yes\" required> Agree</label></form><script type=\"module\" src=\"/widget.js\">hydrate()</script></section><figure class=\"code-window\"><figcaption>theme.json</figcaption><pre><code class=\"language-json\">{&quot;version&quot;:2}</code></pre></figure><div class=\"code-frame\" data-filename=\"functions.php\"><pre><code class=\"language-php\">&lt;?php add_action();</code></pre></div></main>"
},
"expected_blocks": [
{ "path": "blocks.0", "name": "core/group" },
Expand Down Expand Up @@ -45,10 +45,15 @@
{ "path": "blocks.0.innerBlocks", "assert": "count", "count": 7 },
{ "path": "fallbacks", "assert": "count", "count": 2 },
{ "path": "fallbacks.0.controls.0.placeholder", "assert": "equals", "value": "you@example.com" },
{ "path": "fallbacks.0.controls.1.type", "assert": "equals", "value": "checkbox" },
{ "path": "fallbacks.0.controls.1.label", "assert": "equals", "value": "Agree" },
{ "path": "fallbacks.0.controls.1.required", "assert": "equals", "value": true },
{ "path": "fallbacks.0.context.parent_tag", "assert": "equals", "value": "section" },
{ "path": "fallbacks.1.attributes.src", "assert": "equals", "value": "/widget.js" },
{ "path": "fallbacks.1.context.parent_tag", "assert": "equals", "value": "section" },
{ "path": "fallbacks.1.html", "assert": "equals", "value": "" },
{ "path": "fallbacks.1.body", "assert": "equals", "value": "hydrate()" },
{ "path": "fallbacks.1.body_truncated", "assert": "equals", "value": false },
{ "path": "serialized_blocks", "assert": "contains", "value": "<figure class=\"wp-block-image is-resized\"><img src=\"logo.svg\" alt=\"Logo\" width=\"120\" height=\"80\"/></figure>" },
{ "path": "serialized_blocks", "assert": "contains", "value": "<li>Parent<!-- wp:list -->" },
{ "path": "serialized_blocks", "assert": "contains", "value": "theme.json" },
Expand Down