-
-
Notifications
You must be signed in to change notification settings - Fork 10
fix: auth/CLI hardening v0.8.43 — closes #5, closes #6 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7db9888
fix(#6.1): resolve symlinks in direct-run guard
942821c
fix(#6.2): add shebang + exec bit to dist/cli.mjs post-build
ae60549
fix(#6.3): cache keytar probe + add PERPLEXITY_DISABLE_KEYCHAIN=1 esc…
fd85176
fix(#6.4): use persistent browser context for login runners
d53b008
fix(#5.3): add diagnostic logging to getSavedCookies empty paths
0c935a5
fix(#5.1): strip HEADLESS_ONLY/NO_DAEMON from daemon spawn env
c841124
fix(#5.2): Phase 2 uses persistent context + selective vault cookie i…
c1f6dab
test: regression tests for #5/#6 fixes + adjust existing tests
f51e7cb
build(mcp-server): avoid tsup DTS worker OOM by delegating to tsc --a…
d8f6fa8
fix(review): suppress misleading 'key absent' log on unseal failure +…
ee8568f
chore: bump to 0.8.43 + CHANGELOG for issues #5 and #6
a196df7
feat(#daemonSync): live daemon↔UI auth status sync
cfcd8ff
fix(ci): commit missing post-build-shebang.mjs + re-arm watcher on pr…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| #!/usr/bin/env node | ||
| /** | ||
| * Post-build shebang injection for dist/cli.mjs. | ||
| * | ||
| * tsup intentionally omits shebang from bundled output because a shebang in | ||
| * source files trips vitest/esbuild during test imports. However, the npm | ||
| * package.json `bin` field points directly at `dist/cli.mjs`; on POSIX npm | ||
| * creates a symlink (not a wrapper script), so the kernel needs the shebang | ||
| * to exec the file directly. | ||
| * | ||
| * This script prepends `#!/usr/bin/env node` and ensures the file is | ||
| * executable (0o755). It is a no-op on Windows where the kernel ignores | ||
| * shebangs and npm uses `.cmd` wrappers anyway. | ||
| */ | ||
| import { readFileSync, writeFileSync, chmodSync, existsSync } from "node:fs"; | ||
| import { join } from "node:path"; | ||
|
|
||
| const file = join(import.meta.dirname, "..", "dist", "cli.mjs"); | ||
| if (!existsSync(file)) { | ||
| console.error("post-build-shebang: dist/cli.mjs not found"); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| const content = readFileSync(file, "utf8"); | ||
| if (content.startsWith("#!/usr/bin/env node")) { | ||
| console.log("post-build-shebang: already present, skipping"); | ||
| process.exit(0); | ||
| } | ||
|
|
||
| writeFileSync(file, "#!/usr/bin/env node\n" + content); | ||
| chmodSync(file, 0o755); | ||
| console.log("post-build-shebang: injected shebang + chmod 755"); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.