Updates all packages #265
Open
Updates all packages #265
+16,368
−13,173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to all packages, added version overrides for type-fest and ws to fix breaking changes to type-fest and ws dependent packages.
Added additional information to "lineComment" property in language-configuration.json.
LanguageClient has been replaced with BaseLanguageClient in extension.ts.
Replaced { light: string | vscode.Uri; dark: string | vscode.Uri;} with vscode.IconPath in searchTree.ts, icons.ts, and projectTree.ts.
Added encoding: string property to ReadOnlyDocument class in readOnlyDocument.ts
Fixed an always true guard clause in getLispContainerTypeName function in lispContainerServices.ts
added platform property to runTests property as recent versions of VSCode are only available in win32-x64-archive.
typed assert as Chai.Assert in AutoIndent.test.ts and Formatter.test.ts
Changed input into endOfLineEnum2String from 5 to 2 to coincide with a change of CRLF value in EndOfLine enum provided by @Types/vscode
Changed BaseEncodingOptions to EncodingOption due to change in @Types/node
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
…nd, updated a few tests that were looking for outdated parameters to use the new parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Update packages to fix critical security issues in packages and facilitate use of new features in future versions.
Abstractions
Updates to all packages, added version overrides for type-fest and ws to fix breaking changes to type-fest and ws dependent packages.
Added additional information to "lineComment" property in language-configuration.json.
LanguageClient has been replaced with BaseLanguageClient in extension.ts.
Replaced { light: string | vscode.Uri; dark: string | vscode.Uri;} with vscode.IconPath in searchTree.ts, icons.ts, and projectTree.ts.
Added encoding: string property to ReadOnlyDocument class in readOnlyDocument.ts
Fixed an always true guard clause in getLispContainerTypeName function in lispContainerServices.ts
added platform property to runTests property as recent versions of VSCode are only available in win32-x64-archive.
typed assert as Chai.Assert in AutoIndent.test.ts and Formatter.test.ts
Changed input into endOfLineEnum2String from 5 to 2 to coincide with a change of CRLF value in EndOfLine enum provided by @Types/vscode
Changed BaseEncodingOptions to EncodingOption due to change in @Types/node
Tests performed
npm run test and npm run e2etest.