chore: local setup, libs, installs#758
chore: local setup, libs, installs#758jadenblack wants to merge 3 commits intoAutoMaker-Org:mainfrom
Conversation
Summary of ChangesHello @jadenblack, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the local development environment by introducing a robust configuration for custom automation commands, integrating external UI component registries for streamlined development, and establishing a dedicated VSCode workspace for improved project structure. These changes aim to optimize developer workflows and standardize project setup. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughAdds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces local setup configurations and updates dependencies. My review focuses on improving the robustness of these configurations. I've identified an unnecessary and deprecated dependency in package.json that should be removed. Additionally, I've suggested improvements to git commands in the new .ocrm-config.json for better reliability and consistency. Finally, a minor formatting issue in the new workspace file is pointed out to ensure tooling compatibility.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In @.ocrm-config.json:
- Around line 179-186: The "patchAndPublishToNPM" task runs a dangerous command
chain (label "patchAndPublishToNPM" and its "path" string) that auto-commits,
bumps version, pushes, and ends with npm publish which can accidentally publish
non-private sub-packages; remove or isolate the final "npm publish" step (or
require an explicit confirmation flag/environment var), break the chain into
separate safer steps (commit/push, version bump, then a manual/prompted publish)
and ensure the commit message quoting is correct by using proper JSON escaping
or single quotes so the message in the "path" string renders correctly in shells
rather than the fragile \\\" sequence.
- Around line 149-166: The shell command entries for the tasks labeled
"plusversion", "plusversionVSCEPkg", and "commitpush" use pnpm and a hardcoded
commit message; update their "path" strings to use npm (replace "pnpm version
patch" with "npm version patch") to match the repo's npm workspaces, and replace
the fixed commit message ("Cleaning w/ push") with a parameterized or
environment-driven value (e.g., use an environment var like COMMIT_MSG or a
placeholder to prompt) so callers can supply meaningful messages; ensure the
"plusversionVSCEPkg" entry still includes the vsce package step after the npm
version change.
In `@package.json`:
- Line 66: Remove the unnecessary and deprecated "npx" dependency entry from
package.json; locate the "npx": "^10.2.2" line in the
dependencies/devDependencies block and delete that key/value pair, then run npm
install (or yarn) to update lockfiles so the removed package is no longer
present.
🧹 Nitpick comments (2)
docs/alignsynch-automaker.code-workspace (1)
1-12: Workspace file looks fine; minor nit on disabled colorizer settings.
projectColorizer.workspaceColoris set on line 8 butprojectColorizer.enabledisfalseon line 10, making the color a no-op. If the colorizer isn't intended, consider removing the color setting to avoid confusion. Otherwise, no issues..ocrm-config.json (1)
191-232: Multiple empty category folders add noise.MAIN, FILES, OTHER, PRIMARY, SECONDARY, COMPONENTS, and UTILS are all empty. If these are placeholders for future use, consider adding them when they're needed rather than shipping empty scaffolding.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.ocrm-config.json:
- Around line 27-35: The chains labeled "MONO KILL Terminals && Start DEV
Server" and "SINGLE KILL Terminals && Start DEV Server" reference commands named
devApp and startdevSingle which are missing from the config's HIDDEN items (or
elsewhere); either add HIDDEN entries for "devApp" and "startdevSingle" with the
correct command definitions or update the chain "path" values to reference
existing, correctly named commands (e.g., replace devApp/startdevSingle with the
actual command IDs used in the HIDDEN section); look for and update the chain
definitions that contain "saveall, killterms, devApp" and "saveall, killterms,
startdevSingle" or add new HIDDEN items with keys devApp and startdevSingle so
the runtime can resolve them.
| "label": "MONO KILL Terminals && Start DEV Server", | ||
| "path": "saveall, killterms, devApp", | ||
| "type": "chain" | ||
| }, | ||
| { | ||
| "label": "SINGLE KILL Terminals && Start DEV Server", | ||
| "path": "saveall, killterms, startdevSingle", | ||
| "type": "chain" | ||
| }, |
There was a problem hiding this comment.
Chain references devApp and startdevSingle are not defined in this config.
The chains on lines 28 and 33 reference devApp and startdevSingle, but neither appears in the HIDDEN items section (or anywhere else in this file). Unless the consuming extension resolves these from another source, these chains will fail at runtime.
#!/bin/bash
# Check if devApp or startdevSingle are defined elsewhere in the repo
rg -rn 'devApp|startdevSingle' --type json🤖 Prompt for AI Agents
In @.ocrm-config.json around lines 27 - 35, The chains labeled "MONO KILL
Terminals && Start DEV Server" and "SINGLE KILL Terminals && Start DEV Server"
reference commands named devApp and startdevSingle which are missing from the
config's HIDDEN items (or elsewhere); either add HIDDEN entries for "devApp" and
"startdevSingle" with the correct command definitions or update the chain "path"
values to reference existing, correctly named commands (e.g., replace
devApp/startdevSingle with the actual command IDs used in the HIDDEN section);
look for and update the chain definitions that contain "saveall, killterms,
devApp" and "saveall, killterms, startdevSingle" or add new HIDDEN items with
keys devApp and startdevSingle so the runtime can resolve them.
1 participant
Summary by CodeRabbit