Repository navigation
[codex] Polish subscriptions, email layout and resubscription - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After requesting confirmation, readers keep the completed form with feedback below it. This removes the misleading return-to-form CTA, insets native/Radix select arrows, separates confirmation from cancellation/preferences in bilingual HTML/text emails, and automatically confirms from a visible non-prerender landing page.
Resubscription previously left the existing row unsubscribed and never queued confirmation. Explicit fresh consent now starts a new signed-link generation atomically, retaining delivery history and excluding stale links, producers, claims and associated old opt-out callbacks. Suppression and uncertain sends still block reactivation; daily and weekly allowances are unchanged.
Validation: 109 local tests (35 base, 55 news/mail, 11 UI, 8 isolated HTTP), TypeScript, content, lint, build, audit and original bundle budgets passed. Synthetic browser checks cover a single email click producing one automatic confirmation POST, preferences, explicit unsubscribe/cancel, expired links, test isolation and mobile/desktop layout. Signup layout used a local UI response mock; email previews do not prove real inbox delivery. No production secrets/subscriber rows were read and no real mail was sent. Visible JavaScript scanners can still confirm; visibility is not human proof. GET/HEAD/prefetch stay inert and unsubscribe remains explicit.
Publish through the existing Sites project after protected main checks pass. Preserve production configuration, schedules and immutable v1.0.0 tag; no schema or dependency changes.