Repository navigation
Fix subscription confirmation and prepare v1.0.0 - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the confirmation email previously landed readers on a page whose final action was easy to miss, while an existing subscription tab could retain its old availability count. This change puts the active confirmation action first, explains the two steps in both email formats/languages, preserves signed links when switching subscription languages, and refreshes public availability when a tab regains focus or visibility. Signed responses explicitly distinguish public and isolated test subscriptions. GET and email scanning remain read-only; capacity, suppression, idempotency, production configuration and schema are unchanged.
Sets the project version to 1.0.0 and adds public maintenance/release handoff notes. Formal Sites publication and the annotated release tag follow a successful protected merge; candidate documentation does not claim these actions already happened.
Validation: 35 base/compatibility, 42 news/mail, 10 subscription UI and 8 isolated Worker HTTP tests passed (95 total), plus TypeScript, bilingual content, lint and build. Existing security gate passed with 0 high/critical and 8 known moderate advisories. All unchanged bundle budgets passed (JS 919625/920000 bytes). Browser checks at 390×844 and 1440×900 covered read-only landing, bilingual signed navigation, public confirmation/replay, test isolation, expiry, preferences, unsubscribe, and focus-triggered aggregate refresh. No real email, paid API or production subscriber access.
Rollout/rollback: new client requires the subscriptionType response field. Restore matching client/Worker and refresh open pages after rollback; a mixed-version error must not be treated as proof that confirmation failed. Existing tracking and network-access limitations remain documented.