Repository navigation
fix: map ErrInsufficientPermissions to 403 in access-control - #126
Merged
Merged
Conversation
The access-control handler duplicated the core error->status mapping and omitted ErrInsufficientPermissions, so an authorization failure fell through to the default 500 instead of 403. Centralize the mapping in core/errors.StatusFor and have the access-control and admin handlers delegate to it, removing the duplicated switches that caused the drift. Add regression tests covering ErrInsufficientPermissions for both plugins and the shared mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The access-control handler duplicated the core error->status mapping and omitted ErrInsufficientPermissions, so an authorization failure fell through to the default 500 instead of 403.
Centralize the mapping in core/errors.StatusFor and have the access-control and admin handlers delegate to it, removing the duplicated switches that caused the drift.
Add regression tests covering ErrInsufficientPermissions for both plugins and the shared mapping.
Closes #125