Skip to content

Changes: Update src/lib/permissions.ts to return a clear #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fehranbit merged 1 commit into from
Dec 17, 2025
Merged

Changes: Update src/lib/permissions.ts to return a clear #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ export const protectedAction = authActionClient.use(async ({ next, ctx, parsedIn
}
});

if (!projectMember || !hasProjectPermission(projectMember.role, requiredRoles)) {
throw new Error('Not authorized to perform this action on this project.');
if (!projectMember || hasProjectPermission(projectMember.role, requiredRoles).success === false) {
throw new Error('Permission denied: Not authorized to perform this action on this project.');
}

return next({
Expand Down
22 changes: 16 additions & 6 deletions src/lib/permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
import { Role } from '@/generated/prisma/client';
import { Result, success, error, ErrorCodes } from '@/lib/result';

export function hasProjectPermission(userRole: Role, requiredRoles: Role[]): boolean {
return requiredRoles.includes(userRole);
export function hasProjectPermission(userRole: Role, requiredRoles: Role[]): Result<boolean> {
if (requiredRoles.includes(userRole)) {
return success(true);
}
return error<boolean>("Permission denied", ErrorCodes.FORBIDDEN);
}

export function isProjectAdmin(userRole: Role): boolean {
return userRole === Role.ADMIN;
export function isProjectAdmin(userRole: Role): Result<boolean> {
if (userRole === Role.ADMIN) {
return success(true);
}
return error<boolean>("Permission denied", ErrorCodes.FORBIDDEN);
}

export function isProjectMember(userRole: Role): boolean {
return userRole === Role.USER || userRole === Role.ADMIN;
export function isProjectMember(userRole: Role): Result<boolean> {
if (userRole === Role.USER || userRole === Role.ADMIN) {
return success(true);
}
return error<boolean>("Permission denied", ErrorCodes.FORBIDDEN);
}
Loading