Make pgvector and the model registry schema-aware; fix sqlite-vec's engine reconstruction - #57
Open
nicoloesch wants to merge 16 commits into
Open
nicoloesch wants to merge 16 commits into
nicoloesch wants to merge 16 commits into
Conversation
added 6 commits
September 1, 2026 22:56
…urator, adaption of the config, update CI
…figurator, guard schemas properly
added 8 commits
September 15, 2026 00:17
… schema across databases
added 2 commits
September 24, 2026 00:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
-
table_exists, index management, and model-registry lookups all ignored the connection's configured schema, so a non-default-schema pgvector deployment silently read/wrote the wrong tables.Fixed via
oa-configurator's schema-aware primitives, with new non-default-schema regression coverage.create_sqlitevec_engine()no longer rebuilds its own engine from a bare pathEnginedirectly.The model registry now lives in its own reserved schema (
MODEL_REGISTRY_SCHEMA), independent of whichever schema the embedding store itself resolves toThe registry's own
"registry"schema tag is now registered viaregister_reserved_schema_tag()resolve_registry_schema()renamedresolve_registry_physical_schema(), matching thephysical_schema_ofnaming used stack-wide.ReadOnlyEmbeddingStore'sschema/self.schema(inread_only.py) renamedphysical_schemathroughout to prevent ambiguity between a schema tag and a physical schemaAdopts
physical_schema_ofstack-wide.New
test_schema_provenance_guard.py: registry-drift and primary-schema-drift regression tests against live Postgres.Removed
PGVectorEmbeddingBackend.from_db_url()(dead code, zero callers).Breaking changes
create_sqlitevec_engine()'s signature changed fromdb_path_strtoengine: EngineChecklist
breaking)uv run pytest -q): 151 passed, 5 pre-existing unrelated failures