Adjust md5s for updated sample rate in AudioKit#30
Open
emurray2 wants to merge 12 commits intoAudioKit:mainfrom
Open
Adjust md5s for updated sample rate in AudioKit#30emurray2 wants to merge 12 commits intoAudioKit:mainfrom
emurray2 wants to merge 12 commits intoAudioKit:mainfrom
Conversation
This should make CI tests pass. If so, need to update the md5 for new sample rate
Sample rate of 48000Hz changes the delay of the flanger slightly changing the sound, but the effect functions the same
Calculate endpoint using Settings.sampleRate and update md5
Made duration a bit longer so audio doesn't get cutoff with faster sample rate and updated md5
Validated the sample rate being passed into the synth core matched Settings.sampleRate. The audio matches as well, but using audio.audition() uses a default sample rate of 44_100 when the player format isn't specified. This causes the sound to be lower or higher pitched depending on the sample rate. Thus, I used manual engine rendering instead of audition and it sounded the same. Will add a commit to AudioKit later to improve the audition functionality so it matches Settings.sampleRate.
Validated audio sounds the same as described in the previous commit
Validated audio with same procedure as described in previous commits
Validated audio with same procedure as described in previous commits
Validated audio with the same procedure as described in previous commits
Validated audio with the same procedure as described in previous commits
Now the sample rate is configured and the tests use md5 for both intel and M chips--these should work consistently. Keep an eye on them though.
Move these to effects tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AudioKit/AudioKit@de25aa2 Changed the sample rate to match the iOS 18 48kHz value. This changes the md5's for these tests since the nodes use AudioKit to render.
These commits update the md5's for each test and introduce necessary changes to keep the sample rate consistent throughout the tests.