feat(auth): role-based access control with granular permissions - #216
Merged
Merged
Conversation
…loses AudioBitsStellar#100) Introduce an RBAC layer that authorizes admin actions against named permissions rather than roles directly: - Permission enum + ROLE_PERMISSIONS map (LISTENER/ARTIST have none, MODERATOR moderates content, ADMIN manages users/roles, SUPER_ADMIN holds every permission) - requirePermission(permission) middleware: 401 unauthenticated, 403 when the role lacks the capability - New MODERATOR and SUPER_ADMIN roles on UserRole - Per-route permission guards on admin routes (content moderation, search rebuild, jobs, role assignment) - UserService.assignRole + AdminController.assignRole + AssignRoleDTO for POST /admin/users/:id/role - Idempotent migration adding the role column - 16 tests across permission map, middleware, service, and controller Also removes pre-existing unused imports in User.ts and UserService.ts surfaced by lint-staged on the touched files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@dev-susa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100
Summary
Adds an RBAC layer that authorizes admin actions against named permissions rather than roles directly. Callers declare the capability they need; the map decides which roles have it.
Permissionenum +ROLE_PERMISSIONSmap — LISTENER/ARTIST have none, MODERATOR moderates content, ADMIN manages users/roles, SUPER_ADMIN holds every permissionrequirePermission(permission)middleware — 401 when unauthenticated, 403 when the authenticated role lacks the capabilityMODERATORandSUPER_ADMINroles onUserRoleUserService.assignRole+AdminController.assignRole+AssignRoleDTOforPOST /admin/users/:id/roleTesting
16 tests across four suites (permission map,
requirePermissionmiddleware,UserService.assignRole,AdminController.assignRole) — all passing.