Auto store items on container based on inscribed regex#608
Auto store items on container based on inscribed regex#608AquariusPower wants to merge 38 commits intoAttnam:masterfrom
Conversation
update from main
(ready) New monsters (Attnam#349)
update from main
(ready) bug fix for show items under (Attnam#369)
(ready) Fantasy name generator (Attnam#363)
update from main
update from main
update from main
update from main
update from main
update from main
update from main
update from main
update from main
updating
udpating
update from main
update from main
update form main
…to copy from SomeFixes1234 ...)
uses pcre regex (pcre compile code unified at festring); works for normal pickup and auto-pickup; Inscribe containers with a valid regex for it to work!
red-kangaroo
left a comment
red-kangaroo
left a comment
There was a problem hiding this comment.
This is great!
- The message for storing an item in a container should come after the message for picking it up:
- Items will be stored in containers even when they are locked. There should be a check if you can open the container before trying to auto-store an item inside.
agreed, if to move the code (that stores the item) becomes too complicated, just moving the message (store it in a var to display later) would suffice.
could check if it is locked, and then store only if we have a key to open it. |
That would be nice.
I would consider that bug abuse. :D Also the player might end up with items stored in chests he doesn't have a key for. |
|
Are we good to merge this @red-kangaroo ? |
I think there should at least be the check not to store items in locked containers. That could bite the player in the proverbial ass quite easily. :) I will try having a look at that, maybe during holidays. |
| if(lRemainingVol<itToStore->GetVolume()) | ||
| continue; | ||
|
|
||
| if(itc->IsAutoStoreMatch(itToStore->GetName(DEFINITE))){ |
There was a problem hiding this comment.
I think changing this line to
if(!itc->IsLocked() && itc->IsAutoStoreMatch(itToStore->GetName(DEFINITE))){
suffices to solve #608 (comment) request
3 participants
just inscribe a regex in the container
works for pickup and auto-pickup
(split from #587 using
meldfolder compare)