[codex] Add release remote approval gate#104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTK_RELEASE_REMOTE_APPROVEDas an explicit signal for approved public remotes in strict release gates.Why
After maintainer release approval, strict release-audit was still blocked by the configured Git remote warning. This makes that approval explicit and auditable instead of leaving strict mode permanently blocked on an approved public remote.
Verification
cargo fmt --checkcargo test git_remote_warning_requires_explicit_release_approval -- --nocapturecargo testcargo clippy --all-targets --all-features -- -D warningscargo run --locked -- release-auditAGENTK_REQUIRE_SIGNING_KEY=1 AGENTK_RELEASE_REMOTE_APPROVED=1 AGENTK_SIGNING_KEY_FILE=../agentk-release-signing-key cargo run --locked -- release-audit --strictcargo run --locked -- verify-signatures .agentk/runs/latest.jsonl --trusted-public-key <release-public-key>