Skip to content

Desktop: show a line when the agent leaves a tool out because the server refused its schema - #1230

Merged
sosidudku1 merged 1 commit into
rel/xp-buildfrom
fix/ato-1417-dropped-tool-notice-desktop
Nov 12, 2026
Merged

sosidudku1 merged 1 commit into
rel/xp-buildfrom
fix/ato-1417-dropped-tool-notice-desktop

Conversation

@sosidudku1

@sosidudku1 sosidudku1 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Desktop half of ATO-1417. The agent half is #1221 (stacked on #1148).

What was wrong

When LM Studio or llama.cpp refuses an MCP tool's JSON schema, the agent (after #1148) resends the request without that tool. The desktop chat said nothing, so the person saw a model that never used their tool.

What changes

  • renderer.js: a tool_disabled frame (agent with Say in the chat when a tool is left out because the server refused its schema #1221, extensions stream) draws one system line in the turn, before the reply: the agent's own notice ("Tool X is disabled for this turn: the model server did not accept its schema."), or the same sentence built from tool when a frame has no notice. A frame naming no tool draws nothing.
  • tool_disabled joins LIVE_DRAWS, so a frame that arrives while the chat is not on screen is kept and drawn when it is opened again, like provider_switched.

Old and new agents

An agent without #1221 never sends the frame, so nothing changes. An older desktop with a new agent already ignores the frame: agent-client.ts forwards every named frame as kind: <name> and onChatEvent has no branch for an unknown kind.

Tests (written, not run)

  • desktop/test/tool-disabled-line.test.mjs: the line from notice, the fallback from tool, empty for nothing, and the router wiring.

Checked on the second Mac on 12.11.2026 in the combined run with the other open PRs: build, lint, test types, vitest, desktop unit tests, desktop smoke and live smoke all green.

…ver refused its schema

The agent sends a tool_disabled frame (ATO-1417) with the sentence for
the chat. Draw it as one system line in the turn, before the reply. An
agent that never sends the frame changes nothing.
@sosidudku1
sosidudku1 merged commit 633faba into rel/xp-build Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant