Repository navigation
Desktop: show a line when the agent leaves a tool out because the server refused its schema - #1230
Merged
sosidudku1 merged 1 commit intoNov 12, 2026
Conversation
…ver refused its schema The agent sends a tool_disabled frame (ATO-1417) with the sentence for the chat. Draw it as one system line in the turn, before the reply. An agent that never sends the frame changes nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop half of ATO-1417. The agent half is #1221 (stacked on #1148).
What was wrong
When LM Studio or llama.cpp refuses an MCP tool's JSON schema, the agent (after #1148) resends the request without that tool. The desktop chat said nothing, so the person saw a model that never used their tool.
What changes
renderer.js: atool_disabledframe (agent with Say in the chat when a tool is left out because the server refused its schema #1221, extensions stream) draws one system line in the turn, before the reply: the agent's ownnotice("Tool X is disabled for this turn: the model server did not accept its schema."), or the same sentence built fromtoolwhen a frame has nonotice. A frame naming no tool draws nothing.tool_disabledjoinsLIVE_DRAWS, so a frame that arrives while the chat is not on screen is kept and drawn when it is opened again, likeprovider_switched.Old and new agents
An agent without #1221 never sends the frame, so nothing changes. An older desktop with a new agent already ignores the frame:
agent-client.tsforwards every named frame askind: <name>andonChatEventhas no branch for an unknown kind.Tests (written, not run)
desktop/test/tool-disabled-line.test.mjs: the line fromnotice, the fallback fromtool, empty for nothing, and the router wiring.Checked on the second Mac on 12.11.2026 in the combined run with the other open PRs: build, lint, test types, vitest, desktop unit tests, desktop smoke and live smoke all green.