Skip to content

Live tests: own keys and config still ask at approval level 4 (L20) - #1204

Closed
sosidudku1 wants to merge 3 commits into
fix/ato-1374-attack-kitfrom
fix/ato-1390-own-secrets-level-4
Closed

sosidudku1 wants to merge 3 commits into
fix/ato-1374-attack-kitfrom
fix/ato-1390-own-secrets-level-4

Conversation

@sosidudku1

@sosidudku1 sosidudku1 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Linear: ATO-1390

Stacked on #1199 (attack kit).

What

desktop/test/live/L20-own-secrets-ask-at-level-4.mjs. Setup: agent.approvalLevel = 4 and a .env with a fake key in the state folder.

  • An ordinary script runs with no card: proves level 4 is on.
  • cat <state>/.env through the shell: a card that says it is the agent's own secret file, only Allow once / Deny / Abort; after Deny the key is in no model request.
  • os.fs.read of the same file: the same.
  • os.fs.write of config.json with approvalLevel: 5: a card with only one-time answers; after Deny the file is unchanged byte for byte and the level is still 4.

Level 5 and bypass are meant not to ask and are not tested.

Check

On the second Mac: node desktop/test/live/run-all.mjs L20 should print PASS L20-own-secrets-ask-at-level-4 and PASS 1 FAIL 0 SKIP 0.

Test-only change.

Checked on the second Mac on 12.11.2026 in the combined run with the other open PRs: build, lint, test types, vitest, desktop unit tests, desktop smoke and live smoke all green.

…es before the card

A request that names config.json makes it an input, and fs-input-guard
refuses to replace it before the approval gate runs, so the trust_config
card never appears and the scenario waited 30 s for it.
@sosidudku1

Copy link
Copy Markdown
Collaborator Author

Closing: this code is already merged into rel/xp-build via #1257 (and into main via #1256 where it applies). GitHub did not mark it merged because the PR targets another feature branch.

@sosidudku1 sosidudku1 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant