Repository navigation
fix(desktop): Studio asks Core again after a failed engine check and shows the catalog without waiting - #1191
Closed
sosidudku1 wants to merge 2 commits into
Closed
sosidudku1 wants to merge 2 commits into
sosidudku1 wants to merge 2 commits into
Conversation
…he catalog without waiting for Core A failed ask for the image engine was kept as 'missing' and never asked again, so Download stopped refusing on a computer that cannot run local generation. Only a definite answer is kept now; Download asks again on click. The catalog waits at most 1.5 s for the engine, overlapping paints share one ask, and a late answer repaints the page as an engine event.
…nto fix/ato-1420-studio-engine-status
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: ATO-1420 (item 3). Stacked on #1161.
Problem. If Studio's first engine status request to Core failed, the engine was kept as
missingand never asked again. On a computer that can't generate images locally, Download then no longer refused. The first catalog paint also waited up to 30 s for Core, where before it showed right away when Core was down.Change (
desktop/main/studio-local-models.ts,studio-media.ts):ready,unsupported, andmissingwhen Core names a build for this computer). A failed ask keeps nothing, so the next call (including Download's own check) asks again and can refuse withENGINE_UNSUPPORTED.engineevent. Images and Video already reload the catalog on it.ENGINE_ASK_ON_PAINT_MS). If Core is slower, the page paints without it and reloads when the answer arrives. Overlapping paints share one ask.Tests (
desktop/test/studio-local.test.mjs, 4 new): a failed first ask isn't kept and Download asks again; a definite answer is kept; a slow Core gives null quickly with one call, then the event; the local section returns in under 1.5 s when the engine never answers. Worth runningstudio-images.test.mjsandstudio-video.test.mjsin the same pass.Checked on the second Mac on 12.11.2026 in the combined run with the other open PRs: build, lint, test types, vitest, desktop unit tests, desktop smoke and live smoke all green.