Repository navigation
fix(desktop): stop the provider wizard crashing when left mid-step - #1179
Draft
sosidudku1 wants to merge 1 commit into
Draft
sosidudku1 wants to merge 1 commit into
sosidudku1 wants to merge 1 commit into
Conversation
A wizard step awaiting the network could outlive its wizard. After Cancel and Add provider again (row cleared, phase pick_kind), the step resumed, set pick_model and redrew with no row, and wizardHTML threw reading row.custom. wizardHTML now draws the provider list when there is no row, and the wizard steps stop after each await once their wizard was left or reopened on another row, dropping the entry they left without a model. Refs ATO-1281
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Careful tier: touches logic outside the UI, please review closely.
What
wizardHTMLdraws the provider list when the wizard has a phase but no provider row, instead of throwing.wizStepLeft(k): after each await inwizNextStepandwizSubscriptionStep, a step that resumes after the wizard was closed or reopened on another row stops there. It drops its own unfinished entry, the same cleanup leaving the wizard already does, and no longer pops the closed wizard back up.desktop/test/wizard-left-mid-step.test.mjsin the existing vm harness style.Why
Desktop 0.0.7 crash report: TypeError in
wizardHTML(k.customwithk = WIZ.rowempty), reached fromwizNext→wizNextStep→render. Cancel only clears the phase, and Add a provider resets the row. A step still waiting on a key check or the model list then set a new phase and redrew a wizard with no row, which took down the whole window.How it was verified
Not yet checked on the second Mac: this draft waits for one combined build, test, smoke and e2e run together with the other open fixes.
Static checks so far:
wizardHTMLthrows with no row; with the guards removed the stale step moves the reopened wizard to the model step).wizRemoveIfIncomplete(only drops entries this step created without a model) and the exact branch from the crash report.Left as before: cancelling and reopening on the same provider row while the old step is still pending lets that step continue (no crash, since the row is set);
wizActivateafterswxRunhas no stale-step check.