Repository navigation
fix(overnight): say when the Telegram report could not be sent - #1174
Draft
sosidudku1 wants to merge 2 commits into
Draft
sosidudku1 wants to merge 2 commits into
sosidudku1 wants to merge 2 commits into
Conversation
overnight --notify telegram queues its report in memory until its own Telegram channel is up. When the desktop app or the TUI holds telegram.lock the channel never comes up in the overnight process, which then exits and the report is gone without a word. Before exiting, overnight now gives a still-connecting channel up to 15 s, and if the report is still waiting prints why it was not sent (naming the other agent holding Telegram) and where to read the result. Sending through the lock holder is left as a follow-up. ATO-1358
…am is off Review: without a bot token the channel drops the report at once (nothing is queued), and with Telegram turned off the report waits in a channel that never starts. Both now print the plain reason before exit. ATO-1358
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
overnight --notify telegramqueues its report in memory until its own Telegram channel is up. When the desktop app or the TUI holdstelegram.lock, the channel never comes up in the overnight process, which then exits, and the report is gone without a word.Before exiting,
overnightnow gives a channel that is still connecting up to 15 s. If the report is still waiting, or was dropped at once because no bot token is set up, or Telegram is turned off in this agent's settings, it prints why it was not sent (naming the other agent that holds Telegram) and where to read the result.TelegramChannel.hasPendingTaskReport(taskId)is the new read it uses.Why
Linear: ATO-1358, option "say so at the end of the run". Delivering through the process that holds the lock is a larger change (the lock holder would have to poll for handed-off reports) and is left as a follow-up.
Touches the same lines in
overnight-command.tsandovernight-progress.tsas the PR for ATO-1323; whichever merges second needs a small rebase.How it was verified
overnight-progress.test.ts(the message) andtelegram-channel.test.ts(hasPendingTaskReportbefore and after the flush).overnight --notify telegram) still needs a run.Merge notes
overnight-command.tsandovernight-progress.ts. The merged exit line must beovernightExitCode(final).Not yet checked on the second Mac.