Repository navigation
Studio: notice a model that Generate just loaded - #1158
Draft
sosidudku1 wants to merge 4 commits into
Draft
sosidudku1 wants to merge 4 commits into
sosidudku1 wants to merge 4 commits into
Conversation
…oaded Generate loads a downloaded local model by itself, so telling the user to load it first was wrong. Images and Video now say the model loads when Generate is pressed, or that it is not downloaded yet.
Studio named the machine "this Mac" everywhere: the local model group in the Images and Video pickers, the model row, the footer, the progress card, the mode hints and the first-frame notice. A Windows user saw "On this Mac · free, private" (ATO-1400). The words now follow the platform the bridge reports, the same rule as renderer.js THIS_MACHINE: "this Mac" on macOS and in the demo, "this computer" on Windows and Linux. "Show in Finder" follows the chat's fileManagerName() (Explorer / Folder). The mode-hint rule no longer matches on the hint's own words.
The Images and Video pages read the model catalog once per window. After the first local generation (which loads the model by itself) the footer still said "loads when you press Generate" and the picker "Not loaded" until the window was reloaded (ATO-1394). The shell now hands every non-core BR.studio.onLocal event to the pages' optional onLocal. A page reads the catalog again, quietly and once per burst, when a model finished loading (or failed to), a download finished, a model was removed, or one of its local jobs ended. Only the models' facts change: the chosen model, the form and the prompt stay.
This was referenced Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Images and Video pages read the model catalog once per window. After the first local generation (Generate loads the model by itself) the footer still said "loads when you press Generate" and the picker "Not loaded", until the window was reloaded.
Now the Studio shell passes every non-core
BR.studio.onLocalevent (a model loaded or failed to load, a download finished, a model removed) to each page's optionalonLocal. A page then reads the catalog again, quietly and once per burst, and also after one of its local jobs ends. Only the models' facts change: the chosen model, the form and the prompt stay.Why
Linear ATO-1394 (found while reviewing #1114).
Stack
Stacks on #1114 and #1157 (same files). This PR's own change is the top two commits (the second adds the Images test from review).
How it was verified
desktop/test/studio-shell.test.mjs(events reach the pages, core events do not) anddesktop/test/studio-video.test.mjs(progress events do not re-read, a burst makes one read, the model stays) anddesktop/test/studio-images.test.mjs(the Images page reads the catalog once after a load, a finished download or a removal, never while loading). Not run yet.Not yet checked on the second Mac.