The demo page reads the string catalog from beside the SEF, where the build already puts it - #33
Merged
Merged
Conversation
… build already puts it. index.html fetched src/translations.rdf and pooled it under dist/translations.rdf, the URI the SEF resolves against. The Pages workflow ships lib, dist and vocabs and never src, so the fetch 404ed on atomgraph.github.io, the Promise.all that gates SaxonJS.transform rejected, and the published editor came up with no toolbar and no handlers - while the same page worked locally, where src/ sits beside it. generate-sef.sh copies the catalog into dist/ on every build, and the page cannot run without dist/index.xsl.sef.json from that same build, so dist/translations.rdf is present wherever the page is. Fetching it from there makes the fetch URI and the pool key the same string and leaves the workflow as it is. The test fixtures keep reading ../src/: they are never deployed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published editor at https://atomgraph.github.io/RDFa-Editor/ came up with no toolbar and no annotation handlers after #32 was merged.
index.htmlfetchedsrc/translations.rdfand pooled it underdist/translations.rdf, the URI the SEF resolves against. The Pages workflow shipslib,distandvocabsand neversrc, so the fetch 404ed, thePromise.allthat gatesSaxonJS.transformrejected, and nothing rendered. The same page worked locally, wheresrc/sits beside it.The page now fetches the catalog from
dist/translations.rdf.generate-sef.shcopies it there on every build, and the page cannot run withoutdist/index.xsl.sef.jsonfrom that same build, so the file is present wherever the page is. Fetch URI and pool key become the same string, and the workflow is unchanged. The test fixtures keep reading../src/: they are never deployed.Verification
Assembled
_site/exactly asdeploy-pages.ymldoes and loaded it under Playwright:src/translations.rdf,SXJS0009transform failed🤖 Generated with Claude Code