[feat](distributed) Add scoped secret plan references - #604
Draft
kaka11chen wants to merge 4 commits into
Draft
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e722907cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kaka11chen
force-pushed
the
feat/issue-547-distributed-secrets-manager
branch
from
August 16, 2026 10:49
7e72290 to
9d91c17
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kaka11chen
marked this pull request as draft
August 16, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScopedSecretRefcontract with deterministic UUIDv8 identity, query/session ownership, DuckDB-selected normalized scope, and read/write capabilities; secret names and credential values never enter the plan or pickle state..duckdb_commitlifecycle namespace; hard-reject nonstandard lookup semantics, nested selection changes, stale registry state, unsupported providers, ambiguous refs, malformed input, and resource-limit violations.DUCKDB_SOURCE_PATH-correct mbedTLS includes.This is the inactive discovery/transport foundation from #588. It does not resolve, refresh, or install credentials on Ray workers and does not yet enable user-visible multi-scope distributed I/O; worker resolution remains a later broker task. No compatibility or ambient-credential fallback state is carried.
Related issue
close: #588
Documentation impact
AstroVela/vane-website.The contract remains internal and inactive until the worker broker/resolution work is implemented.
Validation
scripts/format workspace --changedSKBUILD_BUILD_DIR="$PWD/build/python-release",SKBUILD_CMAKE_BUILD_TYPE=Release, anduv pip install . --no-build-isolation.unittest "[secret]"— 14 test cases passed, 159 assertions; 5 S3-server-dependent cases skipped.scripts/run_installed_pytest.sh tests/fast/test_scoped_secret_refs.py tests/fast/test_ray_connection_snapshot.py— 84 passed.scripts/run_release_tests.sh— non-Ray: 553 passed, 15 deselected; real Ray: 11 passed, 557 deselected.Checklist
licenses and are recorded where required.
weights, or build artifacts are included.
and untrusted input have been considered.
changes passed relevant checks.