Skip to content

create_commits.py: dont assume utf-8 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

create_commits.py: dont assume utf-8 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions create_commits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,16 @@ def get_file_contents_at_commit(commit_hash: str, filename: str) -> str:
Returns:
bytes: The contents of the file, encoded in utf-8
"""
# get the file contents as utf-8 bytes
text_contents = subprocess.run(
# get the file contents as raw bytes (not text mode, to support binary files)
raw_contents = subprocess.run(
["git", "show", f"{commit_hash}:{filename}"],
stdout=subprocess.PIPE,
text=True,
text=False,
check=True,
).stdout.encode("utf-8")
).stdout

# encode the file contents as a base64 string and return the string
return base64.b64encode(text_contents).decode("utf-8")
return base64.b64encode(raw_contents).decode("utf-8")


def get_file_changes_from_local_commit_hash(commit_hash: str) -> FileChanges:
Expand Down