Repository navigation
Fix run_command hanging on backgrounded command lists - #99
Open
Vamsi-2581 wants to merge 3 commits into
Open
Vamsi-2581 wants to merge 3 commits into
Vamsi-2581 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #98.
run_commandnow captures stdout and stderr in temporary files and waits for the shell process itself, so backgrounded command lists do not keep pipe readers blocked waiting for EOF.Root cause
The shell can exit while a background child still holds inherited stdout/stderr pipes open. The existing concurrent readers waited for those pipes to close before returning, causing
run_commandto block until the background job exited or the timeout fired.Changes
echo && sleep ... &pattern, synchronized to ensure the foreground output has been written before the shell returns.Validation
lintandtype-checkworkflows are awaiting maintainer approval for this fork PR.