Fix Velocity 4 injection and add backend startup notifications - #110
Draft
iareanthony wants to merge 2 commits into
Draft
Fix Velocity 4 injection and add backend startup notifications#110iareanthony wants to merge 2 commits into
iareanthony wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance disclosure
Codex was used to assist with diagnosing the Velocity 4 compatibility issue, preparing the code changes, and refining the implementation. The resulting changes were reviewed, tested, and validated by the contributor before submission.
Summary
This change fixes
PlayerLifecycleListenerinitialization under Velocity 4 and adds player-facing title notifications while managed backend servers start.Changes
javax.inject.Injectwithcom.google.inject.InjectRoot cause
Under Velocity 4, Guice did not recognize the listener constructor annotated with
javax.inject.Inject, causing Impulse initialization to fail with: