Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
rmrt1n
requested changes
Mar 16, 2026
zulkhair
force-pushed
the
daim/feat_s3_adapter_for_snapshot
branch
from
03683f2 to
1d8860c
Compare
rmrt1n
force-pushed
the
daim/feat_s3_adapter_for_snapshot
branch
from
1d8860c to
0066227
Compare
rmrt1n
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added AWS S3 support as a new snapshot storage backend for Cardinal worlds.
What changed?
S3Storagethat stores snapshots in S3 buckets using the key pattern{org}/{project}/{serviceId}/snapshotStorageTypeS3alongside existing NOP and JetStream optionsCARDINAL_S3_BUCKET,CARDINAL_S3_ENDPOINT)How to test?
You can test it using
world start --snapshot-storage=s3using this version of world-clihttps://github.com/Argus-Labs/monorepo/pull/602
Why make this change?
This enables Cardinal worlds to use S3 for snapshot persistence, providing a scalable cloud storage option beyond the existing JetStream and NOP backends. S3 storage offers durability, versioning capabilities, and compatibility with various cloud providers and self-hosted solutions like MinIO.