refactor: system init + add new search modifiers#875
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
winton-library
requested changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Better system init abstraction (yet again..) and new component search modifiers.
Component search modifiers
I see a lot of helper functions in rampage to filter over the results of
Iter, which IMO isn't that great as it makes understanding what a system does harder as you have to jump between different functions. These modifiers hope to fix this by allowing you to filter on the spot so you don't lose context:Filter results
Filterreturns only the entities that matches your predicate:Limit results
Limitreturns only the firstNresults.Return a single element
Singlereturns a single result. It returns an error if the result is empty or has more than one element. This is a shorthand for finding singleton components. If you want to find the first result of a component that exists in multiple entities, useLimit(1).Chaining modifiers
You can chain these functions together for complex searches, e.g.
Internal changes
This PR includes several improvements:
pkg/cardinal/system.go.This consolidates everything in one place. I don't know why it took me so long to realize this. The way to go is to just expose ECS APIs and call them from the system fields. It's much cleaner now and less confusing.
Nothing too special here. The existing version does a lot of boxing because the containers hold interfaces. Replaced it with the same approach as the archetype columns.