Restore compatibility with Diffsky#46
Open
aphearin wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
@zaidikumail I'm not sure I'm able to finish this PR on my own - there is some obsolete code that is being imported and used that is causing import errors, and I'm not sure whether you have fully migrated away from the old code. |
Collaborator
|
@aphearin, no worries. I will finish this PR at some point this week. |
Collaborator
Author
|
Ok great - no rush at all on my account, just wanted to make sure you knew I'd taken this as far as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: This PR fixes broken imports due to upstream changes in Diffsky, e.g.:
phot_utils.pymodule diffsky#450soft_histogramsdirectory to store all the ndhist variants diffsky#449