-
Notifications
You must be signed in to change notification settings - Fork 0
Hw13 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArchieSW
wants to merge
2
commits into
hw12
Choose a base branch
from
hw13
base: hw12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hw13 #16
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,12 +9,12 @@ | |
| import dev.archie.handymanservice.landscape.HandymanClient; | ||
| import dev.archie.handymanservice.landscape.LandscapeService; | ||
| import dev.archie.handymanservice.landscape.Order; | ||
| import dev.archie.handymanservice.landscape.OrderClient; | ||
| import dev.archie.handymanservice.landscape.WorkStatus; | ||
| import dev.archie.handymanservice.landscape.dto.CreatingOrderDto; | ||
| import dev.archie.handymanservice.landscape.dto.HandymanDto; | ||
| import dev.archie.landscapeservice.order.dto.SendOrderToUser; | ||
| import lombok.RequiredArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.kafka.core.KafkaTemplate; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import java.util.List; | ||
|
|
@@ -36,7 +36,7 @@ public class HandymanService { | |
| private final AccountService accountService; | ||
|
|
||
| private final HandymanClient handymanClient; | ||
| private final OrderClient orderClient; | ||
| private final KafkaTemplate<String, Object> kafkaTemplate; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. лучше в отдельный класс и пакет kafka.producer |
||
|
|
||
| /** | ||
| * @param creatingHandymanDto handyman dto create. Email should not exist | ||
|
|
@@ -125,8 +125,9 @@ private Handyman mapUserToHandyman(HandymanDto createdUser, CreatingHandymanDto | |
| .build(); | ||
| } | ||
|
|
||
| public boolean orderAJob(UUID innerId, Order order) { | ||
| public void orderAJob(UUID innerId, Order order) { | ||
| if (!handymanRepository.existsByInnerId(innerId)) { | ||
| kafkaTemplate.send("landscape.order.cancel", order); | ||
| throw new NoSuchUserException(innerId.toString()); | ||
| } | ||
| boolean acceptedTheJob = order.getSkills().stream() | ||
|
|
@@ -136,8 +137,8 @@ public boolean orderAJob(UUID innerId, Order order) { | |
| log.info(innerId + " принял работу"); | ||
| } else { | ||
| log.info(innerId + " отказался от работы"); | ||
| kafkaTemplate.send("landscape.order.cancel", order); | ||
| } | ||
| return acceptedTheJob; | ||
| } | ||
|
|
||
| public void getTheJobDone(Order order, UUID innerId) { | ||
|
|
@@ -148,14 +149,7 @@ public void getTheJobDone(Order order, UUID innerId) { | |
| throw new RuntimeException("Execution was interrupted" + e); | ||
| } | ||
| order.setStatus(WorkStatus.DONE); | ||
| CreatingOrderDto updatingDto = CreatingOrderDto.builder() | ||
| .status(order.getStatus()) | ||
| .fieldId(order.getField().getId()) | ||
| .userId(innerId) | ||
| .workType(order.getWorkType()) | ||
| .skills(order.getSkills().stream().map(Skill::getName).toList()) | ||
| .build(); | ||
| orderClient.update(order.getId(), updatingDto); | ||
| kafkaTemplate.send("landscape.order.complete", new SendOrderToUser(null, order)); | ||
| log.info(innerId + " выполнил работу"); | ||
| } | ||
|
|
||
|
|
||
4 changes: 4 additions & 0 deletions
4
handyman-service/src/main/java/dev/archie/handymanservice/landscape/User.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
handyman-service/src/main/java/dev/archie/landscapeservice/order/dto/SendOrderToUser.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package dev.archie.landscapeservice.order.dto; | ||
|
|
||
| import dev.archie.handymanservice.landscape.Order; | ||
| import dev.archie.handymanservice.landscape.User; | ||
|
|
||
| public record SendOrderToUser( | ||
| User handyman, | ||
| Order order | ||
| ) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
лучше вынести в отдельный класс и пакет kafka.consumer