Conversation
| handymanService.delete(id); | ||
| } | ||
|
|
||
| @PostMapping("/order/{innerId}") |
Collaborator
There was a problem hiding this comment.
не соотносится с методологией REST
| import java.util.UUID; | ||
|
|
||
| public interface HandymanRepository extends MongoRepository<Handyman, String> { | ||
| boolean existsByInnerId(UUID innerId); |
Collaborator
There was a problem hiding this comment.
Лучше добавить чуть больше контекста в наименования
|
|
||
| public void evaluateTheOrder(OrderDto orderDto) { | ||
| log.info("По данному запросу копателей не нашлось. Измените объем работ."); | ||
| // по-хорошему тут нужно держать соединение с клиентом, но представим, что мы его уведомили |
Collaborator
There was a problem hiding this comment.
Таких комментариев тут не должно быть
| public void evaluateTheOrder(OrderDto orderDto) { | ||
| log.info("По данному запросу копателей не нашлось. Измените объем работ."); | ||
| // по-хорошему тут нужно держать соединение с клиентом, но представим, что мы его уведомили | ||
| Random random = new Random(); |
Collaborator
There was a problem hiding this comment.
Лучше вынести на уровень класса
| gardenerService.delete(id); | ||
| } | ||
|
|
||
| @PostMapping("/notify/missingWorkers") |
Collaborator
There was a problem hiding this comment.
не соответствует методологии REST
| foundHandymen.add(handyman); | ||
| } | ||
| }); | ||
| return foundHandymen.stream().limit(3).toList(); |
Collaborator
There was a problem hiding this comment.
число вынести в константу
|
|
||
| @Transactional | ||
| public void resolve() { | ||
| Optional<Order> firstCreatedOrder = orderRepository.findFirstCreatedOrder(); |
Collaborator
There was a problem hiding this comment.
лучше сделать select for share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.