Repository navigation
CI: upload the JVM crash report and minidump when an examples job fails (refs #352) - #364
Merged
Merged
Conversation
The Windows examples leg of PR #351 crashed in the JVM (EXCEPTION_ACCESS_VIOLATION in jvector VamanaDiversityProvider.isDiverse) and both files HotSpot wrote were lost: hs_err_pid<pid>.log in the per-user log directory (-XX:ErrorFile, src/arcadedb/jvm.py, _logdir.py) and hs_err_pid<pid>.mdmp in the working directory (examples/). The existing upload only took examples/*.log. Two steps on failure(), one artifact each per matrix leg, 14 days, if-no-files-found: ignore. They are separate because upload-artifact keeps one root directory per artifact and on Windows the log directory (C:) and the workspace (D:) have no common ancestor. include-hidden-files is on for the Linux directory (~/.local); the patterns name only hs_err_pid files. Refs #352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #352. The one HotSpot crash I saw in a Windows examples run left a crash report and a minidump on the runner, and both were lost with it. This uploads them as artifacts when the examples job fails, and uploads nothing, without an error, when there is no such file.
hs_err_pid*.logis written to the package's per-user log directory (-XX:ErrorFileinsrc/arcadedb/jvm.py, the directory per OS insrc/arcadedb/_logdir.py), and on Windows the minidumphs_err_pid*.mdmpgoes to the working directory of the process, which isexamples/(scripts/run_examples.sh).C:and the workspace onD:, so one step would fail exactly when a crash left both files.actions/upload-artifactas the rest of the workflow,if: failure(),if-no-files-found: ignore, 14 days of retention.I ran
actionlintand the repository's pre-commit hooks on the changed file. What I have not verified: that a real crash writes the files into these paths on a runner (the Windows paths match the one crash in #352; the Linux and macOS paths come from the code, and the Linux one assumesXDG_STATE_HOMEis unset on the runners).🤖 Generated with Claude Code