Map SLOT_NAME_DPI_BUTTON to DpiToggle and add verification tests - #703
Open
ediaz2 wants to merge 1 commit into
Open
Map SLOT_NAME_DPI_BUTTON to DpiToggle and add verification tests#703ediaz2 wants to merge 1 commit into
ediaz2 wants to merge 1 commit into
Conversation
Greptile SummaryThis PR recognizes Logitech’s
Confidence Score: 5/5The PR appears safe to merge because the new alias follows the established DPI-toggle identity and is directly covered by a regression test. The change narrowly extends an existing fixed-name mapping without altering surrounding geometry behavior, and the added test verifies both the original and new metadata names.
|
| Filename | Overview |
|---|---|
| crates/openlogi-desktop/src/features/mouse/geometry.rs | Adds the MX Vertical DPI-button slot alias to the existing visual control mapping with direct regression coverage; no actionable defect was identified. |
Reviews (1): Last reviewed commit: "feat: map SLOT_NAME_DPI_BUTTON to DpiTog..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MX Vertical's top button is missing from the UI because Logitech names the slot
SLOT_NAME_DPI_BUTTONinstead of the usualSLOT_NAME_MODESHIFT_BUTTON. Both refer to the same control, so we add pattern matching to recognize both.Changes
geometry.rs: mapSLOT_NAME_DPI_BUTTONtoButtonId::DpiTogglealongsideSLOT_NAME_MODESHIFT_BUTTONTesting
cargo fmt --all -- --check— cleancargo clippy --workspace --all-targets -- -D warnings— cleancargo test --workspace— clean, including new test for DPI button slot namesFixes #103
