Skip to content

feat(gui): add device default option for keyboard bindings - #702

Open
clifinger wants to merge 1 commit into
AprilNEA:masterfrom
clifinger:feat/keyboard-restore-default
Open

feat(gui): add device default option for keyboard bindings#702
clifinger wants to merge 1 commit into
AprilNEA:masterfrom
clifinger:feat/keyboard-restore-default

Conversation

@clifinger

Copy link
Copy Markdown

Summary

Adds a "Device default" option to the keyboard F-row action picker to allow users to unassign bindings and restore native HID++ behavior.

Changes

  • openlogi-desktop: Inject a "Device default" row at the top of panel_action_rows in function_row.rs which calls commit_keyboard_binding(trigger, None).

Testing

  • Verified locally that the button is rendered and works to unassign keyboard shortcuts.
  • Full local gate passed (cargo fmt, cargo clippy, cargo test).

Fixes #702

@clifinger
clifinger requested a review from AprilNEA as a code owner August 20, 2026 05:14
@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown

Greptile Summary

Adds a “Device default” entry to the keyboard function-row action panel so users can remove an override and restore native device behavior.

  • Displays the option as selected when no binding exists.
  • Clears and persists the selected key’s binding when clicked.
  • Refreshes the function-row view after the reset.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The new row uses the established binding-removal path, which clears persisted and runtime state so unassigned function keys return to native pass-through behavior.

Important Files Changed

Filename Overview
crates/openlogi-desktop/src/features/keyboard/function_row.rs Adds a localized reset row that correctly uses the established None binding semantics and reflects the current default state.

Reviews (1): Last reviewed commit: "feat(gui): add device default option for..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant