feat(gui): add device default option for keyboard bindings - #702
Open
clifinger wants to merge 1 commit into
Open
feat(gui): add device default option for keyboard bindings#702clifinger wants to merge 1 commit into
clifinger wants to merge 1 commit into
Conversation
Greptile SummaryAdds a “Device default” entry to the keyboard function-row action panel so users can remove an override and restore native device behavior.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The new row uses the established binding-removal path, which clears persisted and runtime state so unassigned function keys return to native pass-through behavior.
|
| Filename | Overview |
|---|---|
| crates/openlogi-desktop/src/features/keyboard/function_row.rs | Adds a localized reset row that correctly uses the established None binding semantics and reflects the current default state. |
Reviews (1): Last reviewed commit: "feat(gui): add device default option for..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Device default" option to the keyboard F-row action picker to allow users to unassign bindings and restore native HID++ behavior.
Changes
openlogi-desktop: Inject a "Device default" row at the top ofpanel_action_rowsinfunction_row.rswhich callscommit_keyboard_binding(trigger, None).Testing
cargo fmt,cargo clippy,cargo test).Fixes #702