fix(overlay): prevent GPUI from exiting on window close - #700
Open
clifinger wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR configures the GPUI overlay to quit only explicitly, allowing the process to remain warm after its Actions Ring window closes.
Confidence Score: 5/5The PR appears safe to merge, with no actionable lifecycle or correctness issue identified. The explicit quit mode keeps the overlay alive between window invocations as intended, while existing IPC reconnection and process-replacement paths continue to manage agent disconnects and overlay succession.
|
| Filename | Overview |
|---|---|
| crates/openlogi-overlay/src/main.rs | Configures explicit application quitting so closing the final overlay window no longer terminates the process; no actionable defect was identified. |
Reviews (1): Last reviewed commit: "fix(overlay): prevent GPUI from exiting ..." | Re-trigger Greptile
davidbudnick
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Linux, GPUI closes the application when the last window is closed by default. This causes the
openlogi-overlayprocess to exit every time the Actions Ring is dismissed, leading to a long GPU reinitialization delay upon the next invocation.This PR sets
QuitMode::Expliciton the GPUI app to keep the overlay alive in the background, making subsequent ring invocations instant.Changes
crates/openlogi-overlay/src/main.rs: addedapp.with_quit_mode(gpui::QuitMode::Explicit).Testing
Fixes # (no issue, observed locally)