fix(hid): preserve delayed macOS HID++ responses - #654
Open
safonin wants to merge 4 commits into
Open
Conversation
Greptile SummaryThe PR distinguishes ambiguous macOS HID write completion from definitive failure so delayed HID++ responses remain eligible for matching within the existing request deadline.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security defects identified. The typed outcome is propagated through every in-workspace raw channel implementation, ambiguous macOS completion retains the matcher without retrying, and all definitive or response-less failure paths continue returning errors.
|
| Filename | Overview |
|---|---|
| crates/openlogi-hidpp/src/channel.rs | Preserves pending response matching after unknown write completion while retaining the existing total request timeout and cleanup behavior. |
| crates/openlogi-hidpp/src/channel/raw.rs | Introduces the typed raw-write outcome used to distinguish definitive failure from unknown completion. |
| crates/openlogi-hid/src/transport.rs | Classifies only the exact macOS callback timeout as unknown completion and preserves disconnect handling. |
| crates/openlogi-hid/src/transport/windows.rs | Adapts the Windows transport to the typed error without changing its definitive-failure semantics. |
| crates/openlogi-hidpp/src/channel/tests.rs | Covers delayed-response recovery, final timeout, definitive failure, and response-less write behavior. |
Reviews (1): Last reviewed commit: "fix(hid): classify macos callback timeou..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kIOReturnTimeoutcallback status as an unknown completion result.Changes
0xE00002D6callback status without changing other platform behavior.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceRUSTDOCFLAGS="-D warnings" cargo doc -p openlogi-hid -p openlogi-hidpp -p openlogi-hidpp-derive --no-deps --document-private-itemscargo clippy -p openlogi-hidpp -p openlogi-hid --all-targets --target x86_64-pc-windows-gnu -- -D warningsHardware validation:
046d:b35b, firmwareMPK12.01_0013).0xE00002D6path and matched the delayed response.Part of #521