feat: hw2#9
Open
qqwwee771441 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a Second Order Dynamics model to smooth motion or dampen signals in Unity.
- Introduces a new struct SecondOrderDynamics with overloads for different parameter types
- Implements state update methods and inner parameter recalculations to support the dynamics model
Files not reviewed (19)
- Assets/Cainos/Common.meta: Language not supported
- Assets/Cainos/Common/Script.meta: Language not supported
- Assets/Cainos/Common/Script/Utils.meta: Language not supported
- Assets/Cainos/Common/Script/Utils/SecondOrderDynamics.cs.meta: Language not supported
- Assets/Cainos/Common/Texture.meta: Language not supported
- Assets/Cainos/Common/Texture/Utils.meta: Language not supported
- Assets/Cainos/Common/Texture/Utils/TX Utils Checker.png.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AC Chest Golden.controller: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AC Chest Golden.controller.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AM Chest Golden - Close.anim: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AM Chest Golden - Close.anim.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AM Chest Golden - Closed.anim: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AM Chest Golden - Closed.anim.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AM Chest Golden - Open.anim: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AM Chest Golden - Open.anim.meta: Language not supported
- Assets/Cainos/Pixel Art Platformer - Village Props/Animation/Chest Golden/AM Chest Golden - Opened.anim: Language not supported
Comments suppressed due to low confidence (1)
Assets/Cainos/Common/Script/Utils/SecondOrderDynamics.cs:109
- [nitpick] Consider extracting the magic numbers in this calculation into named constants or adding inline comments explaining their significance to improve code clarity.
k2_stable = Mathf.Max(k2, 1.1f * (t * t * 0.25f + t * k1 * 0.5f));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경점 👍
새로 구현한 기능 및 주요 변경점
버그 해결 💊
해결한 버그
리팩토링 🛠
리팩토링 내역
스크린샷 🖼
변경된 부분에 대한 스크린샷
비고 ✏
리뷰어에게 전하는 말 등
사용하지 않은 항목은 모두 지워주세요.