Skip to content

[codex] Add deployment details review before starting models#66

Merged
skyguan92 merged 3 commits into
developfrom
codex/deploy-detail-review
Jun 4, 2026
Merged

[codex] Add deployment details review before starting models#66
skyguan92 merged 3 commits into
developfrom
codex/deploy-detail-review

Conversation

@xu16601526267

Copy link
Copy Markdown
Contributor

Summary

  • Replace direct model-list deployment with a deployment details modal for reviewing AIMA recommendations before startup.
  • Add editable engine, resource policy, slot, port, and launch parameter controls, plus model info, quantization, VRAM estimate, and tuning suggestions.
  • Wire edited parameters into both deploy.dry_run and deploy.run, persist device-local defaults through backend deploy.defaults, and close the modal immediately after confirming startup.

Validation

  • git diff --check -- internal/ui/static/index.html internal/ui/handler_test.go internal/mcp/tools_deploy.go internal/mcp/tools_deploy_test.go
  • Windows: go test ./internal/mcp ./internal/ui
  • WSL clean checkout: go test ./internal/mcp ./internal/ui
  • WSL go test ./... was attempted. It passed the touched/critical packages, but the existing internal/external TestScanContinuesAfterUnreachableEndpoint timed out after 10 minutes outside this PR's changed files.

@xu16601526267 xu16601526267 force-pushed the codex/deploy-detail-review branch from bb38778 to 3b1538d Compare May 17, 2026 14:47
@skyguan92 skyguan92 merged commit 6ef45b2 into develop Jun 4, 2026
1 check passed
@skyguan92 skyguan92 deleted the codex/deploy-detail-review branch June 4, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants