dashboard and controllerInformation#4
Open
bhuvnesh17 wants to merge 12 commits into
Open
Conversation
Contributor
|
@bhuvnesh17 , changes look good. But do we need ControllerInformation in aws commons too, can't we use ControllerInformation from our commons? |
Author
|
@satish-m We are using this file as a place holder to send the controllerInfo data from the config.yml to the commons library where it expects it as a map of controllerInfo, and then uses this info to generate the ControllerInfo object. |
… with the new addition of ControllerInfo and dashboard fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.