Skip to content

scalafmt fix + check formatting on pull requests - #203

Merged
prabhu merged 3 commits into
mainfrom
fix/scalafmt-and-pr-format-check
Oct 12, 2026
Merged

prabhu merged 3 commits into
mainfrom
fix/scalafmt-and-pr-format-check

Conversation

@prabhu

@prabhu prabhu commented Oct 12, 2026

Copy link
Copy Markdown
Contributor
  • Formats JsSupport.scala (introduced by Fix Windows test failures from PR #201 #202): main's push build failed scalafmtCheck because the PR workflow never checked formatting.
  • Runs sbt scalafmtCheck clean +test in pr-tests on every OS, so a formatting slip fails the PR instead of main.

scalafmtCheck ran only on pushes to main, so a formatting slip merged
green and broke main's build (JsSupport.scala in #202). The pr-tests
jobs now run it before clean +test.
@prabhu
prabhu enabled auto-merge October 12, 2026 20:52
Maven Central is rate-limited from CI: the sbt launcher failed to
download org.scala-sbt:sbt with not-found while the artifact
demonstrably existed. COURSIER_REPOSITORIES now lists Google's mirror
of Central before repo1 (and the private repo), which steers both the
sbt launcher and the build's dependency resolution.
@prabhu prabhu added the ai-auto A person set the task, and AI agents carried it through to completion label Oct 12, 2026
@prabhu
prabhu added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit 63a048f Oct 12, 2026
@prabhu
prabhu deleted the fix/scalafmt-and-pr-format-check branch October 12, 2026 22:44
@prabhu prabhu added this to the v4.0.0 Pelorus milestone Oct 28, 2026
@prabhu prabhu moved this to Done in AppThreat roadmap Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto A person set the task, and AI agents carried it through to completion

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant