Remove unused deepdiff dependency - #2674
Open
tmilnthorp wants to merge 1 commit into
Open
tmilnthorp wants to merge 1 commit into
tmilnthorp wants to merge 1 commit into
Conversation
`deepdiff` is declared in the runtime dependencies but never imported anywhere in the AppDaemon codebase. Dropping it (and its now-orphaned `orderly-set` transitive) trims the install and removes a package that periodically triggers security advisories despite being unused. See AppDaemon#2673.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2673.
What
deepdiffis declared in[project].dependenciesbut is never imported anywhere in the AppDaemon codebase — I grepped the whole tree (including dynamicimport_module/__import__/string references) and there are zero hits outsidepyproject.toml,uv.lock, the Dockerfile comment, and oldHISTORY.mdchangelog lines.This removes it, along with its now-orphaned
orderly-settransitive (nothing else depends on it), and adds aHISTORY.mdentry.Why
Beyond trimming an unused package:
deepdiffperiodically draws security advisories (e.g. the 8.6.1/8.6.2 DoS fixes), which forces downstream packagers to chase versions of a dependency AppDaemon doesn't actually use. Dropping it removes that noise entirely.Notes for the reviewer
uv.lockwas edited minimally on purpose. Running the pinneduv-lockpre-commit hook (uv 0.9.26) regenerates the whole file — it migrates the lock format (revision = 1→3, addsupload-timeto every entry), which turns this into a ~3.7k-line diff unrelated to deepdiff. To keep the change reviewable I removed only thedeepdiff/orderly-setentries and left the rest (andrevision = 1) untouched. Happy to instead run the full regeneration if you'd prefer the format migration to ride along.git rust cargowith the comment "build the orjson package (required by deepdiff)" — butdeepdiff9.x no longer pullsorjson(it's not in the lock at all), so that step already appears dead. I left it out of this PR since I can't test the multi-arch image build locally; flagging it in case you'd like it cleaned up too.Testing
pyproject.tomlanduv.lockboth still parse; theend-of-file,trailing-whitespace,ruff-check, andcodespellpre-commit hooks pass on the changed files. No code importsdeepdiff, so nothing at runtime depends on it.