Chore/security workflow scheduling - #128
Open
akinboyewaSamson wants to merge 6 commits into
Open
Conversation
…d add corresponding test coverage
…n security workflows
Contributor
|
Thanks for tightening up the security workflow! Quick clarification: the green "Dependency Policy (cargo-deny)" and "Dependency Security Audit" runs you can see came from For the merge gate we rely on the four jobs in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #121
Description
Problem: Our security scanning (using cargo-audit and cargo-deny) was previously configured to run solely on a weekly schedule. While helpful for baseline auditing, this left a wide gap where new vulnerabilities could be merged without warning. Since PR-time evaluation is our most valuable line of defense, and daily checks help catch fresh advisories as soon as they are published, the weekly cadence was insufficient for our security posture.
Solution: This PR restructures the security.yml GitHub Actions workflow to operate on a three-tier schedule:
PR-Time (Sentinel Check): Triggers on all pull requests to block vulnerable dependencies from ever entering the main branch.
Nightly (Fresh Advisory Catch): Runs daily at 02:00 UTC to provide the earliest possible detection of newly published RustSec advisories affecting our existing codebase.
Weekly (Baseline Catch-all): Retains the Monday 08:00 UTC schedule as a guaranteed, low-noise baseline.
Changes Made
.github/workflows/security.yml:
Added the pull_request trigger to the workflow.
Added a new daily cron schedule - cron: '0 2 * * *' (02:00 UTC).
Preserved the existing weekly cron schedule - cron: '0 8 * * 1' (Monday 08:00 UTC).
Updated the inline documentation headers to reflect the new three-tier rationale.
Type of Change
Security/Infrastructure update (improves vulnerability detection)
How Has This Been Tested?
YAML Validation: Verified that the syntax for multiple schedule blocks and the pull_request triggers are compliant with GitHub Actions standards.