fix(sidecar): old chats are not imported on a launch that cannot read ~/Documents yet #202

Activity

1. pullfrog commented on Nov 7, 2026

   

   pullfrogBot

   on Nov 7, 2026 – with Pullfrog

   Last edited by pullfrog

   More actions

   No duplicate found. This is a follow-up to #201, which introduces the legacy importer; the relevant code is currently on that PR’s branch, not main.

   Diagnosis
   In sidecar/src/legacy.ts, the initial existsSync(projectsDir) check can hide a permission denial as “missing.” The root statSync/readdirSync calls are also outside the per-project error handler. In sidecar/src/app.ts, import runs only once before the pipe opens, so granting access later cannot trigger recovery. Store.importLegacy() already checks project IDs inside each commit, providing the required duplicate protection.

   Implementation Plan

   1. Replace the permission-masking existence checks with error-aware filesystem reads. Keep missing/non-directory paths harmless; distinguish and log EPERM/EACCES with the affected path, and return enough status to retry unreadable paths. Preserve per-project isolation for malformed files.
   2. Keep the initial import before serving requests. If access is denied, continue startup and schedule non-overlapping, low-frequency retries. Recompute known project IDs before each attempt, suppress repeated identical warnings, and cancel/drain retries before closing the store.
   3. Notify the window after a retry commits new projects. Extend the sidecar event contract and StudioApp.tsx to refresh the project list without resetting the selected chat or unsaved draft; it currently has no project-change subscription.
   4. Add regression tests for denial followed by readability in the same process, missing/non-directory paths, repeated retries without duplicate chats or transcript rereads, and clean shutdown. Inject permission errors for deterministic tests rather than relying solely on chmod. Run sidecar tests/typecheck and the Studio tests, then verify the actual macOS Documents permission flow: grant access while the app stays open and confirm the old chat appears once.

   No code changes or PR created.

     ^{｜ Implement a fix ➔ ｜ View workflow run ｜ via Pullfrog ｜ Using gpt-6.1-sol ｜ 𝕏}
2. pullfrog

   added

   bugSomething isn't workingSomething isn't working

   on Nov 7, 2026