Skip to content

chore(pr-kit): add the PR body checker to hush/0.0.x - #108

Merged
AojdevStudio merged 2 commits into
hush/0.0.xfrom
chore/hush-0.0.x-pr-kit
Oct 30, 2026
Merged

AojdevStudio merged 2 commits into
hush/0.0.xfrom
chore/hush-0.0.x-pr-kit

Conversation

@AojdevStudio

@AojdevStudio AojdevStudio commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Problem

Every PR into hush/0.0.x fails the PR body contract check. The pr-kit workflow runs from main and checks out the PR's base SHA. It then runs .claude/skills/open-pr/check.ts. hush/0.0.x branched before the kit landed, so that file does not exist and PR #101 fails with Module not found.

Change

Both kit folders are copied from main unchanged. Their tree hashes equal main's (open-pr is 5bfb4b0, land-pr is b782f72).

hush/0.0.x
+ .agents/skills/open-pr -> symlink, same as main
+ .agents/skills/land-pr -> symlink, same as main
+ .claude/skills/open-pr/{.pr-kit,VERSION,SKILL.md,check.ts,contract.ts,command.ts,context.ts,gate.ts,kit.ts,pr-kit.yml}
+ .claude/skills/land-pr/{.pr-kit,SKILL.md,merge.ts}

Proof

The first row ran the checker the workflow calls, with PR #101's event payload, on a clean export of each tree.

Check Before (origin/hush/0.0.x) After (3ffe3cf)
bun .claude/skills/open-pr/check.ts --event event.json fails: error: Module not found ".claude/skills/open-pr/check.ts", exit 1 PR body contract: pass. Door two-way, blast radius low., exit 0
bun .claude/skills/open-pr/kit.ts check fails on ad36ae9: ENOENT scanning land-pr VERSION 24 matches the shipped files., exit 0
bun run check not run green, recorded in the review-gate receipt for 3ffe3cf

Review

Finding Disposition Reason
open-pr needs its land-pr sibling, so kit.ts check and gate.ts fail with ENOENT (Pullfrog P2) Fix 3ffe3cf adds land-pr from main. kit.ts check and gate.ts now load.

Merge danger

Door: two-way. Revert this PR to undo it.
Blast radius: low. Only the PR body check reads these files. Package contents, Pi discovery, lint, and typecheck skip them, and bun run check stays green on the branch.

Changes made by Claude Opus 5.5 via Claude Code

…line

The pr-kit workflow runs from main under pull_request_target and checks out
the PR's base SHA to run .claude/skills/open-pr/check.ts. hush/0.0.x branched
before the kit landed, so every PR into it fails with Module not found.
This copies the kit folder from main unchanged.
@coldtea-pr-lens

Copy link
Copy Markdown

Note

The title starts with chore(pr-kit):, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The body checker works in focused tests, but the newly discoverable open-pr skill has a missing sibling dependency that breaks its advertised installation path.

Reviewed changes Reviewed the complete maintenance-branch backport, verified its integration with the workflow on main, and exercised the checker and sibling-dependent entry points.

  • Body validation: Adds the CLI and shared contract for PR titles, draft state, required sections, review dispositions, merge danger, and attribution. Focused acceptance/rejection tests and CLI event probes passed.
  • Skill discovery: Adds the open-pr instructions and .agents symlink, exposing the copied skill to local agents.
  • Supporting kit: Copies the shell parser, PR gate, installer, version markers, and workflow template unchanged from main; the open-pr tree hashes match.
  • CI bootstrap: The existing workflow on main explicitly checks out the PR base SHA, so future events can use this checker after it lands on hush/0.0.x. This PR's current missing-module failure is expected before that bootstrap merge.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6.1-sol | 𝕏

Comment thread .claude/skills/open-pr/kit.ts Resolved
kit.ts digests both skill folders and gate.ts imports ../land-pr/merge.
Without land-pr, kit.ts check and gate.ts fail with ENOENT. Copied from
main unchanged.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Reviewed 3ffe3cf since the prior Pullfrog review, focusing on the added land-pr sibling and its integration with the existing PR kit.

  • Completed the kit: Added the matching land-pr files and discovery symlink, resolving the missing dependency in the installer, gate import, and skill handoff. The sibling tree matches main, and kit.ts check confirms the VERSION 24 digest.
  • Supplied merge decisions: Added the merge-policy module and landing instructions. Focused gate-loading, invalid-body refusal, symlink, and 13 merge-verdict probes passed, including app identity, duplicate signals, and conflict-fix inheritance cases.
  • Preserved bootstrap behavior: Left the workflow unchanged. The current body-check failure still reports the missing checker at the base SHA, as expected until this bootstrap PR lands; repository CI checks are green. The full repository suite was not rerun locally.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@AojdevStudio

Copy link
Copy Markdown
Owner Author

Spec fidelity at 3ffe3cf: no deviations. The goal was to give hush/0.0.x the checker that the pr-kit workflow runs from the base SHA. Both kit folders and their symlinks match main exactly (open-pr tree 5bfb4b0, land-pr tree b782f72). The red PR body check on this PR is the expected bootstrap failure. Its base has no checker until this PR merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant