Implement multi block place preview and complete the initial rendering work of the Celestial Forging Anvil 实现大方块放置预览和完成锻星砧初期渲染工作#3381
Draft
burin-ljx wants to merge 11 commits intoAnvil-Dev:dev/1.21/1.6from
Conversation
- 新增 CelestialForgingAnvilBlock 类实现多部分块结构 - 添加 CelestialForgingAnvilBlockEntity 实现客户端旋转动画 - 实现 CelestialForgingAnvilBlockEntityRenderer 渲染器 - 注册cfa实体类型和渲染器 - 添加cfa状态定义和资源文件 - 更新合成配方使用切割燧石块替代抛光燧石块 - 添加cfa掉落表和物品模型
- 将FlexibleMultiPartBlockItem和SimpleMultiPartBlockItem中的getMaxOffsetDistance方法改为public - 在方块放置失败时触发渲染高亮事件的冷却机制 - 新增RenderHighlightEventListener类处理客户端渲染高亮逻辑 - 新增InputEventListener类跟踪玩家当前选中的物品 - 新增SegmentedActuator工具类用于分段执行动画任务 - 实现多部件方块放置预览和错误位置高亮显示功能
There was a problem hiding this comment.
Pull request overview
Implements a client-side placement preview outline for multi-part (“large”) blocks, including a failure flash animation and per-block error outlines to help players understand why placement fails.
Changes:
- Added a
RenderHighlightEventlistener to render a combined outline for multipart blocks and red outlines for blocking positions. - Added a small segmented “actuator” utility to drive the failure flash animation.
- Updated multipart block items to attempt offset placement and trigger the failure animation when placement still fails.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/dev/dubhe/anvilcraft/util/SegmentedActuator.java |
New utility to sequence tick-based tasks for the failure flash animation. |
src/main/java/dev/dubhe/anvilcraft/integration/jei/category/multiblock/MultiBlockCraftingCategory.java |
Minor cleanup (remove unused import, make local Minecraft reference final). |
src/main/java/dev/dubhe/anvilcraft/client/event/RenderHighlightEventListener.java |
New client event handler rendering placement preview outlines + failure/error visuals. |
src/main/java/dev/dubhe/anvilcraft/block/item/SimpleMultiPartBlockItem.java |
Exposes max-offset helper and triggers failure animation when placement still fails. |
src/main/java/dev/dubhe/anvilcraft/block/item/FlexibleMultiPartBlockItem.java |
Exposes max-offset helper, triggers failure animation, and uses placement state for offset attempt. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/dev/dubhe/anvilcraft/client/event/RenderHighlightEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/dubhe/anvilcraft/client/event/LargeBlockPlacePreviewEventListener.java
Show resolved
Hide resolved
src/main/java/dev/dubhe/anvilcraft/client/event/LargeBlockPlacePreviewEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/dubhe/anvilcraft/block/item/SimpleMultiPartBlockItem.java
Show resolved
Hide resolved
src/main/java/dev/dubhe/anvilcraft/block/item/FlexibleMultiPartBlockItem.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/dubhe/anvilcraft/client/event/LargeBlockPlacePreviewEventListener.java
Show resolved
Hide resolved
src/main/java/dev/dubhe/anvilcraft/client/event/LargeBlockPlacePreviewEventListener.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/dev/dubhe/anvilcraft/client/event/LargeBlockPlacePreviewEventListener.java
Show resolved
Hide resolved
src/main/java/dev/dubhe/anvilcraft/client/event/LargeBlockPlacePreviewEventListener.java
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import dev.dubhe.anvilcraft.block.state.IFlexibleMultiPartBlockState; | ||
| import dev.dubhe.anvilcraft.client.event.LargeBlockPlacePreviewEventListener; | ||
| import it.unimi.dsi.fastutil.objects.ObjectArrayList; | ||
| import lombok.Getter; |
There was a problem hiding this comment.
'java.util.List' should be separated from previous import group by one line.
burin-ljx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.