Repository navigation
Conversation
Contributor
|
Thanks @jackhogan . If you look at the diff, you'll see that there's some wild string-mangling going on in python, in So I looked into it, and there were a lot of things wrong in mdhtml that you inherited here! One was that md2gfm promised byte-identical results, which is the opposite of how it's meant to work, so it ignored all our machinery. Secondly, our underlying I've now fixed both of those issues, and recreated your feature on top of it. Thanks for the PR! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support adding an id to a display equation so that it gets numbered and can be cited with e.g.
[@eq-lossfunc], which renders as "Equation 1". This gives papers and other technical documents the same treatment for equations that figures and tables already have.What changes
eqjoinssec,figandtblas a built-in reference type, with the words "Equation" and "Equations".div.math.displayin MDHTML) registers as acaption-kind target.[@eq-lossfunc]resolves to "Equation 1",[-@eq-lossfunc]to "1", and groups work as they do for figures.\tag{n}on its own line to the equation's TeX, which KaTeX and MathJax render as the equation number.md2gfmdoes the same in the source.mdhtml2typstemits#set math.equation(numbering: "(1)")when any equation has an id, labels each one, and opts unlabelled equations out of numbering.\]{#eq-lossfunc}or$${#eq-lossfunc}, now closes the block and attaches to it, as attributes on a fence line do. Before, the closer was not recognised and the block swallowed the rest of the document without a warning. The IAL-below form continues to work; both parse identically.