Repository navigation
feat: add on-demand code layouts (0.5.2) - #9
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c719487c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'code/how.md', | ||
| 'code/why.md', | ||
| 'code/architect.md', | ||
| 'code/interrogate.md', |
There was a problem hiding this comment.
Reject linked code-layout ancestors
If a repository contains .omp-flow/workflow/code as a symlink (for example, from an untrusted checkout or an existing local link), these new managed entries cause both init and update to create or overwrite how.md, why.md, architect.md, and interrogate.md in the link target: their write paths use mkdirSync/writeFileSync without calling the repository confinement guard. The prior workflow resources did not traverse this new code ancestor, so this feature adds an external-write path; validate all managed destinations and fail before writing when an ancestor is linked.
AGENTS.md reference: AGENTS.md:L101-L102
Useful? React with 👍 / 👎.
|
Release scope calibrated by the owner: Linux is the current verification target. The existing Windows Sleep alias-path failure is not a release gate, and no Sleep or platform-specific workflow fix is included. The new linked code-layout ancestor finding is being corrected with the existing generic destination confinement primitive before npm publication; Linux build, 947 checks and actual CLI boundary smoke pass on that correction branch. npm publication has not occurred: the actual publish attempt returned ENEEDAUTH. |
Change
.omp-flow/workflow/code/.Verification
npm run build: passed.npm test: 945 focused checks passed.npm pack --dry-runand actual packed artifact inspection: passed; four layouts present, private Task/cache/runtime state excluded.Boundary
No Runtime/Hook/adapter changes or private Lab records are included. Existing managed init/update follows linked destination directories; this baseline limitation is unchanged and no new filesystem sandbox is claimed. Optional layout navigation is authored guidance, not a measured agent-effectiveness claim.