Open
Conversation
Warnings from external headers are not very interesting for us, so let's disable them by marking them as system includes using `-isystem`.
This warning doesn't seem that interesting to use as it would require bunch of casting, so let's disable it for now.
#pragma comment() is for Microsoft's compiler, not useful for us.
It was undefined at which point the increment happened in these cases.
Casting an enum reference to int reference was a violation of strict aliasing, so use a temp variable instead.
delet-this
force-pushed
the
fix-gui-warnings
branch
from
0a0279c to
adbc237
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gui has some build warnings, let's fix them!
This shouldn't have any functional impact unless undefined behavior was causing something weird before with the sequence point ub and strict aliasing violation. I have tested that the gui works, and that the nix package still builds.
Probably not a bad idea to enable some more warnings after this, see e.g. https://github.com/cpp-best-practices/cppbestpractices/blob/master/02-Use_the_Tools_Available.md#gcc--clang.