Repository navigation
C-181: feat(renderer): trim and cut segments from edits.json - #406
Draft
AndreyBegma wants to merge 3 commits into
Draft
AndreyBegma wants to merge 3 commits into
AndreyBegma wants to merge 3 commits into
Conversation
RunEditsSchema takes a trim and up to 100 ordered, non-touching cuts in timeline ms. checkRunEdits now takes the run's result and reports a cut outside the trimmed range, a trim or cut hiding the failed step, and less than 500 ms of page left (spec 354).
The trim sets the page's source range and each cut is a segment of the time map with no output span (spec 354). Captions, click rings, key badges and scene cards inside a cut or outside the trim are dropped; the cursor jumps across a cut; the camera and the crop follow are planned with the cuts played and held across each join. Mask spans get keys at the cut edges inside a scroll, and with transitions on every cut dissolves from the last source frame before it, carrying that frame's masks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress on Nautelle board card C-181. The description is written when the worker finishes.
Nautelle-Card: C-181